From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: rafael@kernel.org, lenb@kernel.org, bleung@chromium.org,
groeck@chromium.org, chrome-platform@lists.linux.dev,
linux-acpi@vger.kernel.org, guillaume.tucker@collabora.com,
denys.f@collabora.com, ricardo.canuelo@collabora.com
Subject: Re: [PATCH v2] platform/chrome: chromeos_acpi: support official HID GOOG0016
Date: Mon, 31 Jul 2023 10:49:08 +0800 [thread overview]
Message-ID: <ZMchJBy7zlzP1KMN@google.com> (raw)
In-Reply-To: <2b36d93d-16d5-9780-d292-a7d06b6c8e55@collabora.com>
On Fri, Jul 28, 2023 at 12:49:07PM +0500, Muhammad Usama Anjum wrote:
> On 7/28/23 11:54 AM, Tzung-Bi Shih wrote:
> > Support official HID GOOG0016 for ChromeOS ACPI (see [1]).
> >
> > [1]: https://crrev.com/c/2266713
> >
> > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
> Looks good other than the documentation.
>
> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
I didn't attach the R-b tag in v3
(https://patchwork.kernel.org/project/chrome-platform/patch/20230731024214.908235-1-tzungbi@kernel.org/).
Please review the documentation again.
> > --- a/Documentation/ABI/testing/sysfs-driver-chromeos-acpi
> > +++ b/Documentation/ABI/testing/sysfs-driver-chromeos-acpi
> > @@ -1,4 +1,4 @@
> > -What: /sys/bus/platform/devices/GGL0001:*/BINF.2
> > +What: /sys/bus/platform/devices/GOOG0016:*/BINF.2
> Probably just replace the GGL0001:* with G* here and define the G* can be
> GGL0001:* or GOOG0016:*.
Fix it in v3 by appending a new line for "GOOG0016".
> > --- a/Documentation/firmware-guide/acpi/chromeos-acpi-device.rst
> > +++ b/Documentation/firmware-guide/acpi/chromeos-acpi-device.rst
> > @@ -5,9 +5,8 @@ Chrome OS ACPI Device
> > =====================
> >
> > Hardware functionality specific to Chrome OS is exposed through a Chrome OS ACPI device.
> > -The plug and play ID of a Chrome OS ACPI device is GGL0001. GGL is a valid PNP ID of Google.
> > -PNP ID can be used with the ACPI devices according to the guidelines. The following ACPI
> > -objects are supported:
> > +The plug and play ID of a Chrome OS ACPI device is GGL0001 and the hardware ID is
> > +GOOG0016. The following ACPI objects are supported:
> Looks good. Probably GOOG0016 is HID which has higher preference over
> GGL0001 which is CID if both are defined in firmware?
Yes, I also guess so.
next prev parent reply other threads:[~2023-07-31 2:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 6:54 [PATCH v2] platform/chrome: chromeos_acpi: support official HID GOOG0016 Tzung-Bi Shih
2023-07-28 7:49 ` Muhammad Usama Anjum
2023-07-31 2:49 ` Tzung-Bi Shih [this message]
2023-07-28 15:03 ` Guenter Roeck
2023-07-31 2:50 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMchJBy7zlzP1KMN@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=denys.f@collabora.com \
--cc=groeck@chromium.org \
--cc=guillaume.tucker@collabora.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ricardo.canuelo@collabora.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox