From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39F892C9E; Sat, 30 Sep 2023 15:37:49 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-690bfd4f3ebso12037433b3a.3; Sat, 30 Sep 2023 08:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696088268; x=1696693068; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=SFxpcz2a7H2ZjgJ8ssrmjpRaSpMI8na0366gdvXOP5U=; b=fl3j0HTGNxQCQ8A7RQZj3q4RGh4INgJPZGEDCDEFJLmNTaheL0XFOiQzNWmjmwJX7m z0bw5JPZWcAAvK925z5xR0/S/ghEa98e8PSae7wpUNYoCCvPHENqLrUZC+0cqFKzNGP6 wIEn59B+xh/MUaA52FMS6681JiL1spQKhwp6LqKNGl0mo8QAcKGrqt/7/ZpH17rjI0qO vLku/82FzPaHlyPlyeRHCg8GdxESi9cB+jeEf3zyO4EukfIayAzgjTCGA3Zxpzi+IUcq GbkLUfDMscqktZVWP61xmw7Em/AFJMi4Rto4ol5PmrgIs4dvI02xVLldF142zNWdSYcw /ntQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696088268; x=1696693068; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SFxpcz2a7H2ZjgJ8ssrmjpRaSpMI8na0366gdvXOP5U=; b=SsF8o5vBI+J4bBDNTBXnaUx/r+ltpyTgxRTLU2QqTDACO12SVuNGDZ6kH5nzf+ZONP Bk2MuaZBaUkeNeJINMXRoCkMylD6ZVvLYqr0t6NajLh1BSsMo9JH7PI0tzwVl9oXu2Dn lMxKqiucsEDVrdvcGmPvEepuheHjSaKeFl9POJaJKQbltV8bVLIgUWT7YNDtuPcuKjXj kAjWeLXppmbpURkNK0UihMBIgcmIIzKsjAB5M9lFslSCJSb+U/hxWFYUKJMiLfftneIJ cSAukPiIueQA4TblaaYMl4p23NEf/p7ccg2u1uFJ+LbYqBrJXoEGGfBtFKPpMgO5pAlo 6K4w== X-Gm-Message-State: AOJu0YzTxAMiK8gnr+cuhTHtewfyM8BEz+50Vcm989hTcebNxMOkIySy EpaKcqntMqjgroInAbRmR9M= X-Google-Smtp-Source: AGHT+IEMqhKSToJyXm3yTD7cSFnLWSycVL5nK0X/hEUjcO1rvPkbJ0hf7ZvRqV9SvIbBhj0xSyFIPg== X-Received: by 2002:a05:6a00:16c7:b0:68f:ecb9:5fde with SMTP id l7-20020a056a0016c700b0068fecb95fdemr7078816pfc.34.1696088268304; Sat, 30 Sep 2023 08:37:48 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:a90f:2dad:30c1:d923]) by smtp.gmail.com with ESMTPSA id a10-20020a62d40a000000b006926506de1csm17137176pfh.28.2023.09.30.08.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 08:37:47 -0700 (PDT) Date: Sat, 30 Sep 2023 08:37:43 -0700 From: Dmitry Torokhov To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Lee Jones , Linus Walleij , Alexandre Torgue , Pavel Machek , Guenter Roeck , Liang He , linux-stm32@st-md-mailman.stormreply.com, Daniel Lezcano , chrome-platform@lists.linux.dev, Arnd Bergmann , Samuel Holland , Andrey Moiseev , Michal Simek , Ruan Jinjie , Yangtao Li , Jernej Skrabec , joewu =?utf-8?B?KOWQs+S7suaMryk=?= , Miloslav Trmac , Robert Jarzmik , Chen-Yu Tsai , Andy Gross , linux-input@vger.kernel.org, Jeff LaBundy , linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, Maxime Coquelin , Michael Hennerich , Rob Herring , ye xingchen , Kalle Valo , "Steven Rostedt (Google)" , Hans de Goede , Siarhei Volkau , Christophe JAILLET , Jonathan Cameron , Andy Shevchenko , Benson Leung , linux-arm-kernel@lists.infradead.org, Paolo Abeni , Support Opensource , Chen Jun , Greg Kroah-Hartman , Mattijs Korpershoek , "Rafael J. Wysocki" , Konrad Dybcio , Krzysztof Kozlowski , kernel@pengutronix.de, patches@opensource.cirrus.com, Dmitry Baryshkov , Jonathan Corbet , Bjorn Andersson Subject: Re: [PATCH 00/52] input: Convert to platform remove callback returning void Message-ID: References: <20230920125829.1478827-1-u.kleine-koenig@pengutronix.de> <20230924155057.e4k4ruv5iggbt6q6@pengutronix.de> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230924155057.e4k4ruv5iggbt6q6@pengutronix.de> Hi Uwe, Sorry for the spotty responses. On Sun, Sep 24, 2023 at 05:50:57PM +0200, Uwe Kleine-König wrote: > Hello Dmitry, > > On Sat, Sep 23, 2023 at 07:48:21PM -0700, Dmitry Torokhov wrote: > > On Wed, Sep 20, 2023 at 02:57:37PM +0200, Uwe Kleine-König wrote: > > > Hello, > > > > > > this series converts all platform drivers below drivers/input to use > > > remove_new. The motivation is to get rid of an integer return code > > > that is (mostly) ignored by the platform driver core and error prone on > > > the driver side. > > > > > > See commit 5c5a7680e67b ("platform: Provide a remove callback that > > > returns no value") for an extended explanation and the eventual goal. > > > > > > There are no interdependencies between the patches. As there are still > > > quite a few drivers to convert, I'm happy about every patch that makes > > > it in. So even if there is a merge conflict with one patch until you > > > apply or a subject prefix is suboptimal, please apply the remainder of > > > this series anyhow. > > > > Applied the lot (fixing the i8042-sparcio patch subject), thank you! > > Thanks. In the meantime I found out why my process failed here: I only > fixed *.c, but this driver struct is defined in a header file > i8042-sparcio.h. > > This file is only included by drivers/input/serio/i8042.h which in turn > is only included by drivers/input/serio/i8042.c. So there is only one > instance created, but I'd call that unusual anyhow. Right, i8042 is essentially a singleton, and what you see here is an attempt to bolt OF onto a legacy driver that is largely predates the current driver model. I wanted to clean it up, but it is still widely used and I am hesitant to disturb it too much. Thanks. -- Dmitry