From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from grilo.cascardo.info (trem.minaslivre.org [195.201.110.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A44C946424; Thu, 28 Mar 2024 10:25:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.201.110.149 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711621523; cv=none; b=uaMjtG11nYAlO+elDpz5Y3j4EH6gpFvGt3rNlrS7tjaWOGxh+BpOoBP4em/gxNWwUAE0HWSwbSZcG7Mou4hHO61x5TgWSmDH5Gai0/EtA0IIu+yvz6AVY9W6iG9yZ1f2e1NXj+PR2lOHRMJ+5HgZCoTjq8U8D2Nvxcu6pzUxWp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711621523; c=relaxed/simple; bh=d8qZMuxobQ9NQ+uTJ8eeu7ofwq5oepk3x8NbHvHajl8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B5dMw1mHwvBGfhQhv8sOHImFGohZBrSxUw8zI9nN1dYJckRd+Z3cUxdZ7mBl1H/y2J5YbjzNPGtaDh9euOZcC9rV5W6UMDsLb9SHgmPGuTkKVSbAQdwZe/hCuORDkLcQrWDIQDmiqsyX198xAyYU/HbcYTLYUdXeADlyXNnzGcs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=holoscopio.com; spf=pass smtp.mailfrom=holoscopio.com; dkim=pass (2048-bit key) header.d=holoscopio.com header.i=@holoscopio.com header.b=VPL5dvFP; arc=none smtp.client-ip=195.201.110.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=holoscopio.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=holoscopio.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=holoscopio.com header.i=@holoscopio.com header.b="VPL5dvFP" Received: from siri.cascardo.eti.br (unknown [IPv6:2804:431:e7c5:1ab4:6a17:29ff:fe00:4f38]) by grilo.cascardo.info (Postfix) with ESMTPSA id D24D0206F1A; Thu, 28 Mar 2024 07:25:02 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=holoscopio.com; s=mail; t=1711621511; bh=d8qZMuxobQ9NQ+uTJ8eeu7ofwq5oepk3x8NbHvHajl8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VPL5dvFPC9/KvtZR7dhL29GCVfdBABB9ilSj2h62jCjgj3jNASCQmKccKddwNUR2u YsVTDl1IneRVDN1sl2i083vS8wXNrCVnJeOoACNhfDVrxV18sQ8S9BGenJczRpc0Be hohraa2sTtoUaUhF6GKan9BOWJJh9vKv40DsXWvSZ8CFpj1l2j2YugcG3nCrZSpzJf JfbYHtAZWZs34rq1Uaa4aI5+BoEcImc7aJd1GiXE1WUhnk4JeGzQjUFYCYDv3tgZLf OXY2vM83OKFEOE5Zt+d53o4HmJWd36MVVemcJCkR9kV1WBaVNfjBsxNUEWR4fE5V9u fdb8VgUNzIKZw== Date: Thu, 28 Mar 2024 07:24:59 -0300 From: Thadeu Lima de Souza Cascardo To: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" , Len Brown , Robert Moore , Dmitry Torokhov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Benson Leung , Tzung-Bi Shih , Corentin Chary , "Luke D. Jones" , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Daniel Oliveira Nascimento , Pali =?utf-8?B?Um9ow6Fy?= , Matan Ziv-Av , Mattia Dongili , Azael Avalos , Richard Cochran , Jeff Sipek , Ajay Kaher , Alexey Makhalov , VMware PV-Drivers Reviewers , Theodore Ts'o , "Jason A. Donenfeld" , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linux.dev, linux-input@vger.kernel.org, netdev@vger.kernel.org, chrome-platform@lists.linux.dev, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 06/19] platform: classmate-laptop: drop owner assignment Message-ID: References: <20240327-b4-module-owner-acpi-v1-0-725241a2d224@linaro.org> <20240327-b4-module-owner-acpi-v1-6-725241a2d224@linaro.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327-b4-module-owner-acpi-v1-6-725241a2d224@linaro.org> On Wed, Mar 27, 2024 at 08:43:53AM +0100, Krzysztof Kozlowski wrote: > ACPI bus core already sets the .owner, so driver does not need to. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Thadeu Lima de Souza Cascardo > --- > drivers/platform/x86/classmate-laptop.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c > index 2edaea2492df..87462e7c6219 100644 > --- a/drivers/platform/x86/classmate-laptop.c > +++ b/drivers/platform/x86/classmate-laptop.c > @@ -434,7 +434,6 @@ static const struct acpi_device_id cmpc_accel_device_ids_v4[] = { > }; > > static struct acpi_driver cmpc_accel_acpi_driver_v4 = { > - .owner = THIS_MODULE, > .name = "cmpc_accel_v4", > .class = "cmpc_accel_v4", > .ids = cmpc_accel_device_ids_v4, > @@ -660,7 +659,6 @@ static const struct acpi_device_id cmpc_accel_device_ids[] = { > }; > > static struct acpi_driver cmpc_accel_acpi_driver = { > - .owner = THIS_MODULE, > .name = "cmpc_accel", > .class = "cmpc_accel", > .ids = cmpc_accel_device_ids, > @@ -754,7 +752,6 @@ static const struct acpi_device_id cmpc_tablet_device_ids[] = { > }; > > static struct acpi_driver cmpc_tablet_acpi_driver = { > - .owner = THIS_MODULE, > .name = "cmpc_tablet", > .class = "cmpc_tablet", > .ids = cmpc_tablet_device_ids, > @@ -996,7 +993,6 @@ static const struct acpi_device_id cmpc_ipml_device_ids[] = { > }; > > static struct acpi_driver cmpc_ipml_acpi_driver = { > - .owner = THIS_MODULE, > .name = "cmpc", > .class = "cmpc", > .ids = cmpc_ipml_device_ids, > @@ -1064,7 +1060,6 @@ static const struct acpi_device_id cmpc_keys_device_ids[] = { > }; > > static struct acpi_driver cmpc_keys_acpi_driver = { > - .owner = THIS_MODULE, > .name = "cmpc_keys", > .class = "cmpc_keys", > .ids = cmpc_keys_device_ids, > > -- > 2.34.1 >