From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4106813B593 for ; Fri, 29 Mar 2024 20:05:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711742744; cv=none; b=T598uMpZI3CMjB3fyIhkbuwgg5xObtq1YykH8RcWs2aYfwo0lL9Ue1wIawntb+npyQJbnQNuzXukfOAjCkv8mB+y3WVg8xBryCIyFDQFLg/XbKNBriA7k0o3uqnab92ZwTJ7wDLYhxQRY10OeB4ArU1hX8Ly1AuMA/y3ekfUpbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711742744; c=relaxed/simple; bh=Ec/6RCVI90+5kmMw9qGEqm40uw69VDZKsIVsE5g5+vg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JdzM45ilB6qqCohVwNbJkcoenu00Osnrgtbz7wHKVV9ABA0AizpLBTxvSBBfF6vDb+e49XLdfwPZ8Gg2goE2HE9hC0F9cg2xYQ6kaXtzn/VfE50c5agV9BtmlLE5SebwIaWus3wkj4Z5wmIljoG8oQqne9TjBeKpAkGazSNmgpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=I/thrvAw; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="I/thrvAw" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1dee917abd5so135765ad.1 for ; Fri, 29 Mar 2024 13:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711742742; x=1712347542; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u6QCIVlmxeNX27UI/K3Cf9MpcNJg/YZGD58e6DLHxcU=; b=I/thrvAw41mtOigjR8vQ8Zf3jccEPFvKeiz5o9d38DZV8jy9j403TKn7QqZfo25fjS fRoHktjI2lsWTun3buX3TGriXSN2bPxTOVxsM08To5I/ZLWmPvH7dL3fGhvt3T+kNX+l eJ/4/RoXr4o/iII69YnIXWle+UwigmNvxMzNtY5che48YJt+aloRzXwuFVXy98zQDhYj 3uwfL+mG3Z/7nzziD1WHaD7C0uWV1A1orDQqX/ybJ1d83odQo/hISSUl6pzhSxPBM0gX /1PXAi39N4E/9bDxk89cC9SMN+/gXB2QDSurDguv5e5EJrXZsQ7tOAm4At9bSBwFjLOn CALQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711742742; x=1712347542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u6QCIVlmxeNX27UI/K3Cf9MpcNJg/YZGD58e6DLHxcU=; b=IcCMvTt8UQ6BB/GEqDUjYD+tSg/c+c58IfY6TvGGar4gYb7Sm1R0uV/xvkwlxk8Sdj wyaoDSj46KvqYXMGnXINHbDWVzhw5P8Jv/Yy/j/z27uj/IfbLQVzmu5VxxtFBUShje4e Bpdgf+UlFuYnUYXUUdkGuDL++rWNJSVqz4T9p+8B0uJevXOKxfdlB5P81Xj7gIYAujQo impjCMEYxWQRV8TjV3AAEzyof06pKIeXwHBfOMVDHSfF186YQ7nKfsUhbF5ekNkF+4/n erTGeAAZDKh4iCeZrhNAdgcvPj8DDilOVe60QGQzJWSHls3cRYKLFARuKWE7IyFa+vDf N5QA== X-Forwarded-Encrypted: i=1; AJvYcCUtEJhuyKzNXTXkpClO23SCwCqr0PAHHo+YkTpT2NyJwXAGBXraULNFFDUfn88X9GlPTieU4T8MKUId+WyjNKHT99O87hfEGIpUfS/c7FNK X-Gm-Message-State: AOJu0YxmUpf4HNplsa40o9D0jiM4+R/Ab2G0SC60KSkIuUwz/klYuN8X P/z3otvOPAPEvTIGoG/yFVi+C8SLTDQ+uCxSmaxeOer2SuL/uk7Ae8270nXcfQ== X-Google-Smtp-Source: AGHT+IHR2u6fSNoMRhcUTnBmHEFrAZS31d9cCSSGyjAe7qEaUStQSLdDMooRsOItZpLKvV8bNIfR3w== X-Received: by 2002:a17:902:d48d:b0:1e2:573:eecd with SMTP id c13-20020a170902d48d00b001e20573eecdmr227044plg.3.1711742742020; Fri, 29 Mar 2024 13:05:42 -0700 (PDT) Received: from google.com (236.219.125.34.bc.googleusercontent.com. [34.125.219.236]) by smtp.gmail.com with ESMTPSA id w8-20020a056a0014c800b006eac4b45a88sm3467873pfu.90.2024.03.29.13.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 13:05:41 -0700 (PDT) Date: Fri, 29 Mar 2024 20:05:37 +0000 From: Benson Leung To: Tzung-Bi Shih Cc: bleung@chromium.org, groeck@chromium.org, linus.walleij@linaro.org, brgl@bgdev.pl, hverkuil-cisco@xs4all.nl, mchehab@kernel.org, sre@kernel.org, alexandre.belloni@bootlin.com, chrome-platform@lists.linux.dev, pmalani@chromium.org, linux-gpio@vger.kernel.org, linux-media@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, krzk@kernel.org Subject: Re: [PATCH 01/18] media: platform: cros-ec: provide ID table for avoiding fallback match Message-ID: References: <20240329075630.2069474-1-tzungbi@kernel.org> <20240329075630.2069474-2-tzungbi@kernel.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rRhNzJnLQNBrfqfa" Content-Disposition: inline In-Reply-To: <20240329075630.2069474-2-tzungbi@kernel.org> --rRhNzJnLQNBrfqfa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 29, 2024 at 03:56:13PM +0800, Tzung-Bi Shih wrote: > Instead of using fallback driver name match, provide ID table[1] for the > primary match. >=20 > [1]: https://elixir.bootlin.com/linux/v6.8/source/drivers/base/platform.c= #L1353 >=20 > Signed-off-by: Tzung-Bi Shih Reviewed-by: Benson Leung > --- > drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/m= edia/cec/platform/cros-ec/cros-ec-cec.c > index 48ed2993d2f0..8fbbb4091455 100644 > --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c > +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c > @@ -8,6 +8,7 @@ > =20 > #include > #include > +#include > #include > #include > #include > @@ -573,6 +574,12 @@ static void cros_ec_cec_remove(struct platform_devic= e *pdev) > } > } > =20 > +static const struct platform_device_id cros_ec_cec_id[] =3D { > + { DRV_NAME, 0 }, > + {} > +}; > +MODULE_DEVICE_TABLE(platform, cros_ec_cec_id); > + > static struct platform_driver cros_ec_cec_driver =3D { > .probe =3D cros_ec_cec_probe, > .remove_new =3D cros_ec_cec_remove, > @@ -580,6 +587,7 @@ static struct platform_driver cros_ec_cec_driver =3D { > .name =3D DRV_NAME, > .pm =3D &cros_ec_cec_pm_ops, > }, > + .id_table =3D cros_ec_cec_id, > }; > =20 > module_platform_driver(cros_ec_cec_driver); > @@ -587,4 +595,3 @@ module_platform_driver(cros_ec_cec_driver); > MODULE_DESCRIPTION("CEC driver for ChromeOS ECs"); > MODULE_AUTHOR("Neil Armstrong "); > MODULE_LICENSE("GPL"); > -MODULE_ALIAS("platform:" DRV_NAME); > --=20 > 2.44.0.478.gd926399ef9-goog >=20 >=20 --rRhNzJnLQNBrfqfa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCZgcfEQAKCRBzbaomhzOw wp+oAP0fv6/WzZqGqWPQmJLOlfe6a+iJ8ttOgCDy1MUS6lE6DQEAv3lYNnAzPfRH 16H5TWGS1gh5RMmp5cgSHWlwluqezgU= =R7pN -----END PGP SIGNATURE----- --rRhNzJnLQNBrfqfa--