From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Noah Loomans <noah@noahloomans.com>
Cc: Guenter Roeck <groeck@google.com>,
Bhanu Prakash Maiya <bhanumaiya@chromium.org>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Robert Zieba <robertzieba@google.com>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_ec_uart: properly fix race condition
Date: Thu, 11 Apr 2024 10:18:27 +0800 [thread overview]
Message-ID: <ZhdIc3vt3DFvT066@google.com> (raw)
In-Reply-To: <D0GS8UL1WKI5.1PLEUUWOD7B8@noahloomans.com>
On Thu, Apr 11, 2024 at 12:06:33AM +0200, Noah Loomans wrote:
> On 2024-04-10 at 21:48 UTC+02, Guenter Roeck wrote:
> > On Wed, Apr 10, 2024 at 11:29 AM Noah Loomans <noah@noahloomans.com> wrote:
> > > This is my first time contributing to Linux, I hope this is a good
> > > patch. Feedback on how to improve is welcome!
> >
> > The commit message is a bit long, but the patch itself looks good to me.
>
> Hmm yeah it's a bit on a long side. I'm not sure what could be removed
> though, it all seems relevant for understanding the bug and the fix.
Applied with shortening the message slightly.
next prev parent reply other threads:[~2024-04-11 2:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 18:26 [PATCH] platform/chrome: cros_ec_uart: properly fix race condition Noah Loomans
2024-04-10 19:48 ` Guenter Roeck
2024-04-10 22:06 ` Noah Loomans
2024-04-11 2:18 ` Tzung-Bi Shih [this message]
2024-04-11 2:26 ` Guenter Roeck
2024-04-11 16:08 ` Noah Loomans
2024-04-11 16:08 ` Noah Loomans
2024-04-24 8:51 ` patchwork-bot+chrome-platform
2024-04-24 8:52 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhdIc3vt3DFvT066@google.com \
--to=tzungbi@kernel.org \
--cc=bhanumaiya@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noah@noahloomans.com \
--cc=robertzieba@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox