From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E930C1A08CA for ; Thu, 31 Oct 2024 14:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730384031; cv=none; b=Yje/4TpI8Shy8lNGeAnnDAxQejvYyeu9WrR0xrQst2IYz9UIefI5hSBZ6F+1lCvKpXAaxhp/pOGv6coC87BNF7BTpTu+PRL1MpqxSVPUe4Rzo7EmNABd/1fEwY+/QU9lJODavn+gBe0pH9W6hAt0iLR0skkJdCz7V4WWT8wIljg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730384031; c=relaxed/simple; bh=JywwJxQVAHChhIAg5z61taueze37SO4nmFgRUU7ZM20=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jJX/hkv79fKZXI0qaXFaiEge+Ou+4uA1XrEIFKjo6L0wdCdPekZGnpk7Rh+4Z4atP9S2lJtIPyMJDpRspDy0W9CyEN6vHLNZCkhEALKSkQGtUrzYT6zhBfFCIgz/OZFPdkQJnC/3hzEJRIwH28y3aIif0yXHt57SnGC3KhvO1Jo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=elJlNLAm; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="elJlNLAm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730384030; x=1761920030; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JywwJxQVAHChhIAg5z61taueze37SO4nmFgRUU7ZM20=; b=elJlNLAmiUonYGSr7YlNn/zpwFt6lG0/8EynGYNlFuyPKGBq4JReRz3j xB5E1MU3m2Skfg6pQj08xA/6C1PDH/gGL6aQ5LBeN3kkdSQ5IHOA7Uvvm s+Os0oy678kRn187NmHm7YQCeAkFyCAMVz9EY14oFwpAit02Soa8tj8mG kBwRF0ynDWEGgDD0DEor4pbmIffBQqsb5Qc9b4dcxa8AMqH5u0Zv93+wg rCATBT2rAZbRVzz2Sjf6YM+V2wOqUmOsR9KSIm6s8LQ0OjU0ECj8bQ0AT nKNOdOhTOl/jFVtbG4alMEvuWMCIy6lU2+8QiY/6g0+tNz1tQEis9BipN w==; X-CSE-ConnectionGUID: 0XxAavNsSpquVNRR+Ujt4A== X-CSE-MsgGUID: XE2SBWkMSgOie8hneEivzA== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="29893708" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="29893708" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2024 07:13:50 -0700 X-CSE-ConnectionGUID: cokTh+xrRbCvzQMsWs9UBQ== X-CSE-MsgGUID: 4IscBYx1TneV2nt/7HIgbA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,247,1725346800"; d="scan'208";a="113425607" Received: from kuha.fi.intel.com ([10.237.72.152]) by orviesa002.jf.intel.com with SMTP; 31 Oct 2024 07:13:45 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 31 Oct 2024 16:13:44 +0200 Date: Thu, 31 Oct 2024 16:13:44 +0200 From: Heikki Krogerus To: Abhishek Pandit-Subedi Cc: tzungbi@kernel.org, linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev, dmitry.baryshkov@linaro.org, jthies@google.com, akuchynski@google.com, pmalani@chromium.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] usb: typec: Only use SVID for matching altmodes Message-ID: References: <20241030212854.998318-1-abhishekpandit@chromium.org> <20241030142833.v2.2.Ie0d37646f18461234777d88b4c3e21faed92ed4f@changeid> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241030142833.v2.2.Ie0d37646f18461234777d88b4c3e21faed92ed4f@changeid> On Wed, Oct 30, 2024 at 02:28:33PM -0700, Abhishek Pandit-Subedi wrote: > Mode in struct typec_altmode is used to indicate the index of the > altmode on a port, partner or plug. When searching for altmodes, it > doesn't make sense to use the mode as a criteria since it could be any > value depending on the enumeration order of the driver. > > Signed-off-by: Abhishek Pandit-Subedi Reviewed-by: Heikki Krogerus > --- > > Changes in v2: > - Update altmode_match to ignore mode entirely > - Also apply the same behavior to typec_match > > drivers/usb/typec/bus.c | 3 +-- > drivers/usb/typec/class.c | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/typec/bus.c b/drivers/usb/typec/bus.c > index aa879253d3b8..a5cb4bbb877d 100644 > --- a/drivers/usb/typec/bus.c > +++ b/drivers/usb/typec/bus.c > @@ -454,8 +454,7 @@ static int typec_match(struct device *dev, const struct device_driver *driver) > const struct typec_device_id *id; > > for (id = drv->id_table; id->svid; id++) > - if (id->svid == altmode->svid && > - (id->mode == TYPEC_ANY_MODE || id->mode == altmode->mode)) > + if (id->svid == altmode->svid) > return 1; > return 0; > } > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c > index bd41abceb050..85494b9f7502 100644 > --- a/drivers/usb/typec/class.c > +++ b/drivers/usb/typec/class.c > @@ -237,7 +237,7 @@ static int altmode_match(struct device *dev, void *data) > if (!is_typec_altmode(dev)) > return 0; > > - return ((adev->svid == id->svid) && (adev->mode == id->mode)); > + return (adev->svid == id->svid); > } > > static void typec_altmode_set_partner(struct altmode *altmode) > -- > 2.47.0.163.g1226f6d8fa-goog -- heikki