From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: jic23@kernel.org, chrome-platform@lists.linux.dev,
linux-iio@vger.kernel.org, Gwendal Grignou <gwendal@google.com>
Subject: Re: [PATCH v3] iio: cros_ec_sensors: add cros_ec_activity driver
Date: Fri, 23 May 2025 05:14:37 +0000 [thread overview]
Message-ID: <aDAEPcpWHps3l3Fc@google.com> (raw)
In-Reply-To: <20250523031849.1479851-1-gwendal@google.com>
On Thu, May 22, 2025 at 08:18:49PM -0700, Gwendal Grignou wrote:
> ChromeOS EC can report activity information derived from the
> accelerometer:
> - Reports on-body/off-body as a proximity event.
> - Reports significant motion as an activity event.
>
> This new sensor is a virtual sensor, included only when the EC firmware
> is compiled with the appropriate module.
>
> Signed-off-by: Gwendal Grignou <gwendal@google.com>
Looks neat to me. With removing a nit,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_activity.c b/drivers/iio/common/cros_ec_sensors/cros_ec_activity.c
> [...]
> +static int cros_ec_write_event_config(struct iio_dev *indio_dev,
> [...]
> + st->core.param.set_activity.enable = state;
> + if (ret == 0)
> + ret = cros_ec_motion_send_host_cmd(&st->core, 0);
The assignment of `set_activity.enable` should be in the if-branch too.
prev parent reply other threads:[~2025-05-23 5:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 3:18 [PATCH v3] iio: cros_ec_sensors: add cros_ec_activity driver Gwendal Grignou
2025-05-23 5:14 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDAEPcpWHps3l3Fc@google.com \
--to=tzungbi@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=gwendal@chromium.org \
--cc=gwendal@google.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).