* [PATCH v1 1/1] platform/chrome: chromeos_laptop - Remove duplicate check
@ 2025-06-30 10:12 Andy Shevchenko
2025-07-01 7:19 ` Tzung-Bi Shih
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2025-06-30 10:12 UTC (permalink / raw)
To: chrome-platform, linux-kernel
Cc: Benson Leung, Tzung-Bi Shih, Andy Shevchenko
fwnode_remove_software_node() is aware of invalid input,
no need to perform checks in the caller.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/chrome/chromeos_laptop.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c
index 69d366df3e26..dbf256071549 100644
--- a/drivers/platform/chrome/chromeos_laptop.c
+++ b/drivers/platform/chrome/chromeos_laptop.c
@@ -780,8 +780,7 @@ chromeos_laptop_prepare_i2c_peripherals(struct chromeos_laptop *cros_laptop,
while (--i >= 0) {
i2c_dev = &i2c_peripherals[i];
info = &i2c_dev->board_info;
- if (!IS_ERR_OR_NULL(info->fwnode))
- fwnode_remove_software_node(info->fwnode);
+ fwnode_remove_software_node(info->fwnode);
}
kfree(i2c_peripherals);
return error;
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-01 7:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-30 10:12 [PATCH v1 1/1] platform/chrome: chromeos_laptop - Remove duplicate check Andy Shevchenko
2025-07-01 7:19 ` Tzung-Bi Shih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).