From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Tomasz Michalec <tmichalec@google.com>
Cc: Benson Leung <bleung@chromium.org>,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
Jameson Thies <jthies@google.com>,
Andrei Kuchynski <akuchynski@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Konrad Adamczyk <konrada@google.com>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
chromeos-krk-upstreaming@google.com
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Check ec platform device pointer
Date: Wed, 23 Jul 2025 03:24:46 +0000 [thread overview]
Message-ID: <aIBV_mKsV4Yn5XMY@google.com> (raw)
In-Reply-To: <20250722132826.707087-1-tmichalec@google.com>
On Tue, Jul 22, 2025 at 03:28:26PM +0200, Tomasz Michalec wrote:
> It is possible that parent device for cros_ec_typec device is already
> available, but ec pointer in parent driver data isn't populated yet. It
> may happen when cros_typec_probe is running in parallel with
> cros_ec_register. This leads to NULL pointer dereference when
> cros_typec_probe tries to get driver data from typec->ec->ec->dev.
>
> Check if typec->ec->ec is set before using it in cros_typec_probe.
>
> [...]
Please use at least for-next branch as the commit base next time. I have
fixed it this time.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
[1/1] platform/chrome: cros_ec_typec: Check ec platform device pointer
commit: 731a4702b668ef28730e7d2414672b7085e757d6
Thanks!
prev parent reply other threads:[~2025-07-23 3:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 13:28 [PATCH] platform/chrome: cros_ec_typec: Check ec platform device pointer Tomasz Michalec
2025-07-23 3:24 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIBV_mKsV4Yn5XMY@google.com \
--to=tzungbi@kernel.org \
--cc=abhishekpandit@chromium.org \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=chromeos-krk-upstreaming@google.com \
--cc=groeck@chromium.org \
--cc=jthies@google.com \
--cc=konrada@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tmichalec@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox