From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andrei Kuchynski <akuchynski@chromium.org>
Cc: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
Benson Leung <bleung@chromium.org>,
Jameson Thies <jthies@google.com>,
Tzung-Bi Shih <tzungbi@kernel.org>,
linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev,
Guenter Roeck <groeck@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
"Christian A. Ehrhardt" <lk@c--e.de>,
Venkat Jayaraman <venkat.jayaraman@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] platform/chrome: cros_ec_typec: Set alt_mode_override flag
Date: Fri, 5 Sep 2025 12:58:16 +0300 [thread overview]
Message-ID: <aLq0OD_7lIP6B-eJ@kuha.fi.intel.com> (raw)
In-Reply-To: <20250825145750.58820-3-akuchynski@chromium.org>
On Mon, Aug 25, 2025 at 02:57:47PM +0000, Andrei Kuchynski wrote:
> This flag specifies that the Embedded Controller (EC) must receive explicit
> approval from the Application Processor (AP) before initiating Type-C
> alternate modes or USB4 mode.
>
> Signed-off-by: Andrei Kuchynski <akuchynski@chromium.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/platform/chrome/cros_ec_typec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index b712bcff6fb2..c0806c562bb9 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -491,6 +491,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)
>
> cap->driver_data = cros_port;
> cap->ops = &cros_typec_usb_mode_ops;
> + cap->no_mode_control = !typec->ap_driven_altmode;
>
> cros_port->port = typec_register_port(dev, cap);
> if (IS_ERR(cros_port->port)) {
> --
> 2.51.0.rc2.233.g662b1ed5c5-goog
>
--
heikki
next prev parent reply other threads:[~2025-09-05 9:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 14:57 [PATCH v2 0/5] USB Type-C alternate mode priorities Andrei Kuchynski
2025-08-25 14:57 ` [PATCH v2 1/5] usb: typec: Add alt_mode_override field to port property Andrei Kuchynski
2025-09-05 9:57 ` Heikki Krogerus
2025-09-05 11:53 ` Andrei Kuchynski
2025-08-25 14:57 ` [PATCH v2 2/5] platform/chrome: cros_ec_typec: Set alt_mode_override flag Andrei Kuchynski
2025-09-05 9:58 ` Heikki Krogerus [this message]
2025-08-25 14:57 ` [PATCH v2 3/5] usb: typec: ucsi: " Andrei Kuchynski
2025-09-05 9:59 ` Heikki Krogerus
2025-09-05 11:57 ` Andrei Kuchynski
2025-08-25 14:57 ` [PATCH v2 4/5] usb: typec: Implement alternate mode priority handling Andrei Kuchynski
2025-09-05 10:25 ` Heikki Krogerus
2025-09-05 11:59 ` Andrei Kuchynski
2025-08-25 14:57 ` [PATCH v2 5/5] usb: typec: Expose alternate mode priority via sysfs Andrei Kuchynski
2025-09-05 10:34 ` Heikki Krogerus
2025-09-05 12:22 ` Andrei Kuchynski
2025-09-05 11:57 ` [PATCH v2 0/5] USB Type-C alternate mode priorities Heikki Krogerus
2025-09-05 12:41 ` Andrei Kuchynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLq0OD_7lIP6B-eJ@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=abhishekpandit@chromium.org \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lk@c--e.de \
--cc=tzungbi@kernel.org \
--cc=venkat.jayaraman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox