From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2533628E5F3 for ; Fri, 5 Sep 2025 09:58:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757066303; cv=none; b=iSU6/oYPxGTUXgM7X7c0gIVC1kwXwdw9pbRX44AI6sALr405CrjzHFHVgVmsHjolp7YMzFTidt3o6TWt7qh9/lzeX/S7Rcc2chVbizy6nzPGtZCi/Y7dim+NMi3s5RtSSjd1GLGNjGFvI7NRZ2b0d2/KPVxDqXfnFAKoNPTL5/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757066303; c=relaxed/simple; bh=fH/fH9IlI4y4iyWIl9EmyomPqVs0ZCb7wQlHJg8l0wE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jo5d1GK00WnoTk8UsmTE/M5EGJb3YpRbHRC/T1Y9zjhmo3wUPQTfdXD9Ejn0Dj9NEDUAEPDcMKpksl/784YiRr9hq5pVJQhIT5HoLVDnqfDMLHGfAaAMJejp7yEXfiCIxdZLT9Fs8jxqf6FzZbig30xD7Yy+obDxqRps8X/QRKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=db5PG2Gf; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="db5PG2Gf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1757066302; x=1788602302; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fH/fH9IlI4y4iyWIl9EmyomPqVs0ZCb7wQlHJg8l0wE=; b=db5PG2GfI28nnHosiqzbBN03rtLe6M42XT5kDhu3n/FKiZrA5ZaBgY/r TtJMW4ERo5hCfwHMh29uArmivTgE/z5g5jdsOf5+pSVY7zeNFkQ0Oa0W/ 3cQ7f+fyAdGTTeIUF7m/ayTAG7EgQEJ+7gZCFqiqJjolGlX0fQLVZlqS+ sNrYUSpxpEA54yWS/ytraoZyUIrQv8CeSxA78epdwrdkfo+WHcqVYWIlf 2wGhPeAape9f2FncujvMQxPXqFseVQ0/ihSIHS5FGCpt3tP+gf74nXdJt SKH+k/pBOIuRYfC4k7v95p5aFePLzLtBUu3yaQuABrK3S1vx0EdJQMGtj g==; X-CSE-ConnectionGUID: TaH1BEAKTa6OUZqS6753lA== X-CSE-MsgGUID: fgGnNc5zRYeR8FQuuZb5Gg== X-IronPort-AV: E=McAfee;i="6800,10657,11543"; a="58450168" X-IronPort-AV: E=Sophos;i="6.18,240,1751266800"; d="scan'208";a="58450168" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2025 02:58:21 -0700 X-CSE-ConnectionGUID: z3iBlKTRSkixb0iLo9lHyw== X-CSE-MsgGUID: cxdbLLL0T9quPQjZfy/Yfw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,240,1751266800"; d="scan'208";a="172012263" Received: from kuha.fi.intel.com ([10.237.72.152]) by orviesa007.jf.intel.com with SMTP; 05 Sep 2025 02:58:17 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 05 Sep 2025 12:58:16 +0300 Date: Fri, 5 Sep 2025 12:58:16 +0300 From: Heikki Krogerus To: Andrei Kuchynski Cc: Abhishek Pandit-Subedi , Benson Leung , Jameson Thies , Tzung-Bi Shih , linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev, Guenter Roeck , Greg Kroah-Hartman , Dmitry Baryshkov , "Christian A. Ehrhardt" , Venkat Jayaraman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/5] platform/chrome: cros_ec_typec: Set alt_mode_override flag Message-ID: References: <20250825145750.58820-1-akuchynski@chromium.org> <20250825145750.58820-3-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250825145750.58820-3-akuchynski@chromium.org> On Mon, Aug 25, 2025 at 02:57:47PM +0000, Andrei Kuchynski wrote: > This flag specifies that the Embedded Controller (EC) must receive explicit > approval from the Application Processor (AP) before initiating Type-C > alternate modes or USB4 mode. > > Signed-off-by: Andrei Kuchynski Reviewed-by: Heikki Krogerus > --- > drivers/platform/chrome/cros_ec_typec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c > index b712bcff6fb2..c0806c562bb9 100644 > --- a/drivers/platform/chrome/cros_ec_typec.c > +++ b/drivers/platform/chrome/cros_ec_typec.c > @@ -491,6 +491,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec) > > cap->driver_data = cros_port; > cap->ops = &cros_typec_usb_mode_ops; > + cap->no_mode_control = !typec->ap_driven_altmode; > > cros_port->port = typec_register_port(dev, cap); > if (IS_ERR(cros_port->port)) { > -- > 2.51.0.rc2.233.g662b1ed5c5-goog > -- heikki