From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Jameson Thies <jthies@google.com>
Cc: akuchynski@chromium.org, bleung@chromium.org,
abhishekpandit@chromium.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] platform/chrome: cros_usbpd_notify: defer probe when parent EC driver isn't ready
Date: Thu, 2 Oct 2025 19:32:24 +0800 [thread overview]
Message-ID: <aN5iyOsHILi40AIp@tzungbi-laptop> (raw)
In-Reply-To: <20250926202234.3064386-1-jthies@google.com>
On Fri, Sep 26, 2025 at 08:22:34PM +0000, Jameson Thies wrote:
> @@ -15,6 +16,7 @@
> #define DRV_NAME "cros-usbpd-notify"
> #define DRV_NAME_PLAT_ACPI "cros-usbpd-notify-acpi"
> #define ACPI_DRV_NAME "GOOG0003"
> +#define CREC_DRV_NAME "GOOG0004"
What does CREC stand for?
> @@ -114,8 +117,18 @@ static int cros_usbpd_notify_probe_acpi(struct platform_device *pdev)
> /*
> * We continue even for older devices which don't have the
> * correct device heirarchy, namely, GOOG0003 is a child
> - * of GOOG0004.
> + * of GOOG0004. If GOOG0003 is a child of GOOG0004 and we
> + * can't get a pointer to the Chrome EC device, defer the
> + * probe function.
> */
> + parent_fwnode = fwnode_call_ptr_op(dev->fwnode, get_parent);
Does it make more sense to use fwnode_get_parent()?
next prev parent reply other threads:[~2025-10-02 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 20:22 [PATCH v1] platform/chrome: cros_usbpd_notify: defer probe when parent EC driver isn't ready Jameson Thies
2025-09-26 21:34 ` Benson Leung
2025-10-02 11:32 ` Tzung-Bi Shih [this message]
2025-10-02 19:42 ` Jameson Thies
2025-10-03 2:25 ` Tzung-Bi Shih
2025-10-07 0:02 ` Jameson Thies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN5iyOsHILi40AIp@tzungbi-laptop \
--to=tzungbi@kernel.org \
--cc=abhishekpandit@chromium.org \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox