From: Tzung-Bi Shih <tzungbi@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Linux PM" <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Brian Norris" <briannorris@chromium.org>,
"Dan Callaghan" <dcallagh@chromium.org>,
"Sami Kyöstilä" <skyostil@chromium.org>,
"Benson Leung" <bleung@chromium.org>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH v1 18/23] platform/chrome: cros_hps_i2c: Discard pm_runtime_put() return value
Date: Tue, 23 Dec 2025 03:56:16 +0000 [thread overview]
Message-ID: <aUoS4AxGx291bLqF@google.com> (raw)
In-Reply-To: <2302270.NgBsaNRSFp@rafael.j.wysocki>
On Mon, Dec 22, 2025 at 09:27:44PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Passing pm_runtime_put() return value to the callers is not particularly
> useful.
>
> Returning an error code from pm_runtime_put() merely means that it has
> not queued up a work item to check whether or not the device can be
> suspended and there are many perfectly valid situations in which that
> can happen, like after writing "on" to the devices' runtime PM "control"
> attribute in sysfs for one example. It also happens when the kernel is
> configured with CONFIG_PM unset.
>
> Accordingly, update hps_release() to simply discard the return value of
> pm_runtime_put() and always return success to the caller.
>
> This will facilitate a planned change of the pm_runtime_put() return
> type to void in the future.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Tzung-Bi Shih <tzungbi@kernel.org>
prev parent reply other threads:[~2025-12-23 3:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6245770.lOV4Wx5bFT@rafael.j.wysocki>
2025-12-22 20:27 ` [PATCH v1 18/23] platform/chrome: cros_hps_i2c: Discard pm_runtime_put() return value Rafael J. Wysocki
2025-12-23 3:56 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUoS4AxGx291bLqF@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dcallagh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=skyostil@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox