public inbox for chrome-platform@lists.linux.dev
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: briannorris@chromium.org, jwerner@chromium.org,
	javierm@redhat.com, samuel@sholland.org,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	airlied@gmail.com, simona@ffwll.ch,
	chrome-platform@lists.linux.dev, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 00/12] drm, coreboot: Add DRM coreboot driver
Date: Fri, 16 Jan 2026 09:51:21 +0000	[thread overview]
Message-ID: <aWoKGXtYPMm71K9a@google.com> (raw)
In-Reply-To: <07efafb2-30bf-4d45-a53f-114272c1a1b1@suse.de>

On Fri, Jan 16, 2026 at 10:19:03AM +0100, Thomas Zimmermann wrote:
> Hi
> 
> Am 16.01.26 um 10:13 schrieb Tzung-Bi Shih:
> > On Thu, Jan 15, 2026 at 08:57:10AM +0100, Thomas Zimmermann wrote:
> > > Coreboot implements framebuffer support via simple-framebuffer. Provide a
> > > dedicated DRM driver. Keep the simple-framebuffer code for now.
> > > 
> > > For each firmware's provided framebuffer, we prefer a dedicated DRM driver
> > > tailored towards the platform's feature set. The coreboot framebuffer
> > > device currently creates a simple-framebuffer device for the provided
> > > framebuffer aperture. But simple-framebuffer is for DeviceTree nodes; not
> > > for coreboot. The simple-framebuffer infrastructure should be phased out
> > > for non-DT use cases. Coreboot is one of the final users of the code
> > > (besides n64).
> > > 
> > > Patches 1 to 5 start by fixing problems in the coreboot framebuffer
> > > implementation. There is a possible dangling pointer, the memory is
> > > marked as busy, the device hierarchy is incorrect, and a few minor things.
> > > 
> > > Patches 6 to 9 prepare the coreboot support for use by external drivers.
> > > Specifically, structures for the entries os the coreboot payload table
> > > have to be exported.
> > > 
> > > Patches 10 to 12 add corebootdrm, a DRM driver for the new
> > > coreboot-framebuffer platform device. Corebootdrm follows the pattern
> > > established by similar drivers. It also uses the same sysfb helpers. It
> > > is therefore fairly small. With patch 11, it has feature parity with
> > > simpledrm on the old simple-framebuffer. Patch 12 adds support for panel-
> > > orientation flags that coreboot makes available.
> > What would you suggest to submit the patches (e.g., which patches submit
> > through which tree)?  Do they have build-time dependencies?
> 
> The patches have no dependencies besides the coreboot and DRM frameworks
> they operate in. DRM moves a lot faster than coreboot, and you likely don't
> have the latest DRM in the coreboot tree. So I'd take them via DRM, if
> possible.

Let's take this way.  I'll try to review the patches and provide my A-b tag
too if possible.

> Note that there will be at least one more update to this series to address
> review comments.

Sure, no rush.

      reply	other threads:[~2026-01-16  9:51 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15  7:57 [PATCH v2 00/12] drm, coreboot: Add DRM coreboot driver Thomas Zimmermann
2026-01-15  7:57 ` [PATCH v2 01/12] firmware: google: framebuffer: Do not unregister platform device Thomas Zimmermann
2026-01-26  8:28   ` Tzung-Bi Shih
2026-01-15  7:57 ` [PATCH v2 02/12] firmware: google: framebuffer: Do not mark framebuffer as busy Thomas Zimmermann
2026-01-26  8:28   ` Tzung-Bi Shih
2026-01-15  7:57 ` [PATCH v2 03/12] firmware: google: framebuffer: Init memory resource with helper macro Thomas Zimmermann
2026-01-26  8:28   ` Tzung-Bi Shih
2026-01-15  7:57 ` [PATCH v2 04/12] firmware: google: framebuffer: Tie platform device to PCI hardware Thomas Zimmermann
2026-01-26  8:29   ` Tzung-Bi Shih
2026-01-15  7:57 ` [PATCH v2 05/12] firmware: google: framebuffer: Fix dependencies Thomas Zimmermann
2026-01-15 20:54   ` Julius Werner
2026-01-16  7:30     ` Thomas Zimmermann
2026-01-17  1:38       ` Julius Werner
2026-01-29 12:41         ` Thomas Zimmermann
2026-01-26 10:24   ` Tzung-Bi Shih
2026-01-15  7:57 ` [PATCH v2 06/12] firmware: google: Init coreboot bus with subsys_initcall() Thomas Zimmermann
2026-01-26 10:25   ` Tzung-Bi Shih
2026-01-15  7:57 ` [PATCH v2 07/12] firmware: google: Clean up include statements in coreboot_table.h Thomas Zimmermann
2026-01-26 10:25   ` Tzung-Bi Shih
2026-01-15  7:57 ` [PATCH v2 08/12] firmware: google: Export coreboot table entries Thomas Zimmermann
2026-01-26 10:25   ` Tzung-Bi Shih
2026-01-15  7:57 ` [PATCH v2 09/12] firmware: google: Pack structures for " Thomas Zimmermann
2026-01-15 20:56   ` Julius Werner
2026-01-16  7:32     ` Thomas Zimmermann
2026-01-15  7:57 ` [PATCH v2 10/12] drm/sysfb: Generalize pixel-format matching Thomas Zimmermann
2026-01-15  7:57 ` [PATCH v2 11/12] drm/sysfb: corebootdrm: Add DRM driver for coreboot framebuffers Thomas Zimmermann
2026-01-27  7:49   ` Tzung-Bi Shih
2026-01-29 14:56     ` Thomas Zimmermann
2026-01-15  7:57 ` [PATCH v2 12/12] drm/corebotdrm: Support panel orientation Thomas Zimmermann
2026-01-27  7:49   ` Tzung-Bi Shih
2026-01-27  8:04     ` Tzung-Bi Shih
2026-01-29 15:01       ` Thomas Zimmermann
2026-01-15 20:58 ` [PATCH v2 00/12] drm, coreboot: Add DRM coreboot driver Julius Werner
2026-01-16  7:33   ` Thomas Zimmermann
2026-01-16  9:13 ` Tzung-Bi Shih
2026-01-16  9:19   ` Thomas Zimmermann
2026-01-16  9:51     ` Tzung-Bi Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWoKGXtYPMm71K9a@google.com \
    --to=tzungbi@kernel.org \
    --cc=airlied@gmail.com \
    --cc=briannorris@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=jwerner@chromium.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=samuel@sholland.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox