Re: [PATCH v2 1/2] platform: chrome: lightbar: Report number of segments

[Tzung-Bi Shih <tzungbi@kernel.org>]

On Mon, Jan 26, 2026 at 10:34:33PM -0800, Gwendal Grignou wrote:
> Add attribue `num_segments` to return the number of exposed LED segments
> in the lightbar. It can be smaller than the number of physical leds in
> the lightbar.
> 
> Test: Check the attribute is present and returns a value when read.
> 
> Signed-off-by: Gwendal Grignou <gwendal@google.com>
> ---
> Changes in v2:
> - Put local variables at beginning of num_segments_show()
> - Cleanup return logic.
> 
>  drivers/platform/chrome/cros_ec_lightbar.c    | 43 +++++++++++++++++++
>  .../linux/platform_data/cros_ec_commands.h    | 11 +++++

The patch generally looks good to me.  We have to wait the header change
landed in firmware.

> +static ssize_t num_segments_show(struct device *dev,
> +				 struct device_attribute *attr, char *buf)
> +{
> +	struct ec_params_lightbar *param;
> +	struct ec_response_lightbar *resp;
> +	struct cros_ec_command *msg;
> +	struct cros_ec_dev *ec = to_cros_ec_dev(dev);
> +	uint32_t num = 0;
> +	int ret;
> +
> +	ret = lb_throttle();
> +	if (ret)
> +		return ret;
> +
> +	msg = alloc_lightbar_cmd_msg(ec);
> +	if (!msg)
> +		return -ENOMEM;
> +
> +	param = (struct ec_params_lightbar *)msg->data;
> +	param->cmd = LIGHTBAR_CMD_GET_PARAMS_V3;
> +	msg->outsize = sizeof(param->cmd);
> +	msg->result = sizeof(resp->get_params_v3);
             ^^^^^^ insize
It seems you missed the comment from v1.