From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: briannorris@chromium.org, jwerner@chromium.org,
javierm@redhat.com, samuel@sholland.org,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@gmail.com, simona@ffwll.ch,
chrome-platform@lists.linux.dev, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 12/12] drm/corebotdrm: Support panel orientation
Date: Tue, 27 Jan 2026 07:49:46 +0000 [thread overview]
Message-ID: <aXhuGnUlM500G6Ht@google.com> (raw)
In-Reply-To: <20260115082128.12460-13-tzimmermann@suse.de>
On Thu, Jan 15, 2026 at 08:57:22AM +0100, Thomas Zimmermann wrote:
> diff --git a/include/linux/coreboot.h b/include/linux/coreboot.h
> [...]
> @@ -63,9 +68,13 @@ struct lb_framebuffer {
> u8 blue_mask_size;
> u8 reserved_mask_pos;
> u8 reserved_mask_size;
> + u8 orientation;
> } __packed;
>
> #define LB_FRAMEBUFFER_HAS_LFB(__fb) \
> ((__fb)->size >= offsetofend(struct lb_framebuffer, reserved_mask_size))
>
> +#define LB_FRAMEBUFFER_HAS_ORIENTATION(__fb) \
> + ((__fb)->size >= offsetofend(struct lb_framebuffer, orientation))
Wouldn't the new field in struct lb_framebuffer break LB_FRAMEBUFFER_HAS_LFB()?
E.g., fb->size == offsetofend(struct lb_framebuffer, reserved_mask_size)
-> LB_FRAMEBUFFER_HAS_LFB(fb) == true
-> LB_FRAMEBUFFER_HAS_ORIENTATION(fb) == false?
next prev parent reply other threads:[~2026-01-27 7:49 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 7:57 [PATCH v2 00/12] drm, coreboot: Add DRM coreboot driver Thomas Zimmermann
2026-01-15 7:57 ` [PATCH v2 01/12] firmware: google: framebuffer: Do not unregister platform device Thomas Zimmermann
2026-01-26 8:28 ` Tzung-Bi Shih
2026-01-15 7:57 ` [PATCH v2 02/12] firmware: google: framebuffer: Do not mark framebuffer as busy Thomas Zimmermann
2026-01-26 8:28 ` Tzung-Bi Shih
2026-01-15 7:57 ` [PATCH v2 03/12] firmware: google: framebuffer: Init memory resource with helper macro Thomas Zimmermann
2026-01-26 8:28 ` Tzung-Bi Shih
2026-01-15 7:57 ` [PATCH v2 04/12] firmware: google: framebuffer: Tie platform device to PCI hardware Thomas Zimmermann
2026-01-26 8:29 ` Tzung-Bi Shih
2026-01-15 7:57 ` [PATCH v2 05/12] firmware: google: framebuffer: Fix dependencies Thomas Zimmermann
2026-01-15 20:54 ` Julius Werner
2026-01-16 7:30 ` Thomas Zimmermann
2026-01-17 1:38 ` Julius Werner
2026-01-29 12:41 ` Thomas Zimmermann
2026-01-26 10:24 ` Tzung-Bi Shih
2026-01-15 7:57 ` [PATCH v2 06/12] firmware: google: Init coreboot bus with subsys_initcall() Thomas Zimmermann
2026-01-26 10:25 ` Tzung-Bi Shih
2026-01-15 7:57 ` [PATCH v2 07/12] firmware: google: Clean up include statements in coreboot_table.h Thomas Zimmermann
2026-01-26 10:25 ` Tzung-Bi Shih
2026-01-15 7:57 ` [PATCH v2 08/12] firmware: google: Export coreboot table entries Thomas Zimmermann
2026-01-26 10:25 ` Tzung-Bi Shih
2026-01-15 7:57 ` [PATCH v2 09/12] firmware: google: Pack structures for " Thomas Zimmermann
2026-01-15 20:56 ` Julius Werner
2026-01-16 7:32 ` Thomas Zimmermann
2026-01-15 7:57 ` [PATCH v2 10/12] drm/sysfb: Generalize pixel-format matching Thomas Zimmermann
2026-01-15 7:57 ` [PATCH v2 11/12] drm/sysfb: corebootdrm: Add DRM driver for coreboot framebuffers Thomas Zimmermann
2026-01-27 7:49 ` Tzung-Bi Shih
2026-01-29 14:56 ` Thomas Zimmermann
2026-01-15 7:57 ` [PATCH v2 12/12] drm/corebotdrm: Support panel orientation Thomas Zimmermann
2026-01-27 7:49 ` Tzung-Bi Shih [this message]
2026-01-27 8:04 ` Tzung-Bi Shih
2026-01-29 15:01 ` Thomas Zimmermann
2026-01-15 20:58 ` [PATCH v2 00/12] drm, coreboot: Add DRM coreboot driver Julius Werner
2026-01-16 7:33 ` Thomas Zimmermann
2026-01-16 9:13 ` Tzung-Bi Shih
2026-01-16 9:19 ` Thomas Zimmermann
2026-01-16 9:51 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXhuGnUlM500G6Ht@google.com \
--to=tzungbi@kernel.org \
--cc=airlied@gmail.com \
--cc=briannorris@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jwerner@chromium.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox