[PATCH] platform/chrome: cros_ec_lightbar: Fix response size initialization

[PATCH] platform/chrome: cros_ec_lightbar: Fix response size initialization

[Tzung-Bi Shih]

Commit 1e7913ff5f9f ("platform/chrome: cros_ec_lightbar: Reduce
ligthbar get version command") meant to set smaller values for both
request and response sizes.

However, it incorrectly assigned the response size to the `result` field
instead of `insize`.  Fix it.

Reported-by: Gwendal Grignou <gwendal@google.com>
Closes: https://lore.kernel.org/chrome-platform/CAMHSBOVrrYaB=1nEqZk09VkczCrj=6B-P8Fe29TpPdSDgT2CCQ@mail.gmail.com
Fixes: 1e7913ff5f9f ("platform/chrome: cros_ec_lightbar: Reduce ligthbar get version command")
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
As the cut-off date for the next merge window is approaching.  I really
hope to include the fix in the cycle.  Sent the fix by myself.  See also
https://lore.kernel.org/chrome-platform/aXmaQeTV0oTqi_KB@google.com/.

 drivers/platform/chrome/cros_ec_lightbar.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
index 8352e9732791..3702baff5d4f 100644
--- a/drivers/platform/chrome/cros_ec_lightbar.c
+++ b/drivers/platform/chrome/cros_ec_lightbar.c
@@ -126,7 +126,7 @@ static int get_lightbar_version(struct cros_ec_dev *ec,
 	param = (struct ec_params_lightbar *)msg->data;
 	param->cmd = LIGHTBAR_CMD_VERSION;
 	msg->outsize = sizeof(param->cmd);
-	msg->result = sizeof(resp->version);
+	msg->insize = sizeof(resp->version);
 	ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg);
 	if (ret < 0 && ret != -EINVAL) {
 		ret = 0;
-- 
2.53.0.rc2.204.g2597b5adb4-goog

Re: [PATCH] platform/chrome: cros_ec_lightbar: Fix response size initialization

[Tzung-Bi Shih]

On Thu, Jan 29, 2026 at 11:31:13PM -0800, Gwendal Grignou wrote:
> On Thu, Jan 29, 2026 at 8:03 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> 
> > Commit 1e7913ff5f9f ("platform/chrome: cros_ec_lightbar: Reduce
> > ligthbar get version command") meant to set smaller values for both
> > request and response sizes.
> >
> > However, it incorrectly assigned the response size to the `result` field
> > instead of `insize`.  Fix it.
> >
> > Reported-by: Gwendal Grignou <gwendal@google.com>
> > Closes:
> > https://lore.kernel.org/chrome-platform/CAMHSBOVrrYaB=1nEqZk09VkczCrj=6B-P8Fe29TpPdSDgT2CCQ@mail.gmail.com
> > Fixes: 1e7913ff5f9f ("platform/chrome: cros_ec_lightbar: Reduce ligthbar
> > get version command")
> > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
> >
> Reviewed-by: Gwendal Grignou <gwendal@google.com>
> [...]

Applied to

    https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next

[1/1] platform/chrome: cros_ec_lightbar: Fix response size initialization
      commit: ec0dd36dbf8b0b209e63d0cd795451fa2203c736

Thanks!