[PATCH v2] platform/chrome: lightbar: Fix lightbar_program_ex alignment

[PATCH v2] platform/chrome: lightbar: Fix lightbar_program_ex alignment

[Gwendal Grignou]

Make sure sub-command of lightbar command starts with a 8bit
parameter to ensure alignment.

Fixes: 9600b8bdbfe4 ("platform/chrome: lightbar: Add support for large sequence")

Signed-off-by: Gwendal Grignou <gwendal@google.com>
---
Changes in v2:
- Update attribute to `__ec_todo_packed` to fix a clang warning.

 include/linux/platform_data/cros_ec_commands.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
index 144243143034..bddc7568158e 100644
--- a/include/linux/platform_data/cros_ec_commands.h
+++ b/include/linux/platform_data/cros_ec_commands.h
@@ -2026,10 +2026,10 @@ struct lightbar_program {
  * EC RAM.
  */
 struct lightbar_program_ex {
-	uint16_t offset;
 	uint8_t size;
+	uint16_t offset;
 	uint8_t data[0];
-} __ec_todo_unpacked;
+} __ec_todo_packed;
 
 struct ec_params_lightbar {
 	uint8_t cmd;		      /* Command (see enum lightbar_command) */
-- 
2.53.0.rc1.225.gd81095ad13-goog

Re: [PATCH v2] platform/chrome: lightbar: Fix lightbar_program_ex alignment

[Tzung-Bi Shih]

On Mon, Feb 02, 2026 at 12:21:57PM -0800, Gwendal Grignou wrote:
> Make sure sub-command of lightbar command starts with a 8bit
> parameter to ensure alignment.
> 
> [...]

Applied to

    https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next

[1/1] platform/chrome: lightbar: Fix lightbar_program_ex alignment
      commit: d55493f6d2dae3a8e8b50fe82e947781a7735c51

Thanks!