From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: briannorris@chromium.org, jwerner@chromium.org,
javierm@redhat.com, samuel@sholland.org,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@gmail.com, simona@ffwll.ch,
chrome-platform@lists.linux.dev, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 09/12] firmware: google: Pack structures for coreboot table entries
Date: Fri, 6 Feb 2026 05:13:44 +0000 [thread overview]
Message-ID: <aYV4iOKmZgJc0hdb@google.com> (raw)
In-Reply-To: <20260203135519.417931-10-tzimmermann@suse.de>
On Tue, Feb 03, 2026 at 02:52:28PM +0100, Thomas Zimmermann wrote:
> Pack the fields in the coreboot table entries. These entries are part of
> the coreboot ABI, so they don't follow regular calling conventions. Fields
> of type u64 are aligned to boundaries of 4 bytes instead of 8. [1]
>
> So far this has not been a problem. In the future, padding bytes should
> be added where explicit alignment is required.
>
> v2:
> - use aligned 64-bit type instead of __packed__ attribute (Julius)
Changelog should be after "---" otherwise it becomes part of commit message.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Link: https://github.com/coreboot/coreboot/blob/main/payloads/libpayload/include/coreboot_tables.h#L96 # [1]
> Suggested-by: Julius Werner <jwerner@chromium.org>
> Acked-by: Julius Werner <jwerner@chromium.org>
Acked-by: Tzung-Bi Shih <tzungbi@kernel.org>
next prev parent reply other threads:[~2026-02-06 5:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 13:52 [PATCH v3 00/12] drm, coreboot: Add DRM coreboot driver Thomas Zimmermann
2026-02-03 13:52 ` [PATCH v3 01/12] firmware: google: framebuffer: Do not unregister platform device Thomas Zimmermann
2026-02-03 13:52 ` [PATCH v3 02/12] firmware: google: framebuffer: Do not mark framebuffer as busy Thomas Zimmermann
2026-02-03 13:52 ` [PATCH v3 03/12] firmware: google: framebuffer: Init memory resource with helper macro Thomas Zimmermann
2026-02-03 13:52 ` [PATCH v3 04/12] firmware: google: framebuffer: Tie platform device to PCI hardware Thomas Zimmermann
2026-02-03 13:52 ` [PATCH v3 05/12] firmware: google: framebuffer: Fix dependencies Thomas Zimmermann
2026-02-03 13:52 ` [PATCH v3 06/12] firmware: google: Init coreboot bus with subsys_initcall() Thomas Zimmermann
2026-02-03 13:52 ` [PATCH v3 07/12] firmware: google: Clean up include statements in coreboot_table.h Thomas Zimmermann
2026-02-03 13:52 ` [PATCH v3 08/12] firmware: google: Export coreboot table entries Thomas Zimmermann
2026-02-03 13:52 ` [PATCH v3 09/12] firmware: google: Pack structures for " Thomas Zimmermann
2026-02-06 5:13 ` Tzung-Bi Shih [this message]
2026-02-03 13:52 ` [PATCH v3 10/12] drm/sysfb: Generalize pixel-format matching Thomas Zimmermann
2026-02-03 13:52 ` [PATCH v3 11/12] drm/sysfb: corebootdrm: Add DRM driver for coreboot framebuffers Thomas Zimmermann
2026-02-06 5:14 ` Tzung-Bi Shih
2026-02-06 7:44 ` Thomas Zimmermann
2026-02-06 9:20 ` Tzung-Bi Shih
2026-02-16 10:25 ` Javier Martinez Canillas
2026-02-03 13:52 ` [PATCH v3 12/12] drm/sysfb: corebootdrm: Support panel orientation Thomas Zimmermann
2026-02-06 9:21 ` Tzung-Bi Shih
2026-02-16 10:27 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYV4iOKmZgJc0hdb@google.com \
--to=tzungbi@kernel.org \
--cc=airlied@gmail.com \
--cc=briannorris@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jwerner@chromium.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox