From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
Dustin Howett <dustin@howett.net>
Subject: Re: [PATCH] platform/chrome: cros_kbd_led_backlight: enable probing through EC_FEATURE_PWM_KEYB
Date: Mon, 6 May 2024 19:38:09 +0200 [thread overview]
Message-ID: <ae29f036-5e39-47ee-98d3-c023a263a3ef@t-8ch.de> (raw)
In-Reply-To: <cd9c5b6a-0155-434a-b868-a9ea52e878c9@amd.com>
On 2024-05-05 08:42:21+0000, Mario Limonciello wrote:
> On 5/5/2024 04:41, Thomas Weißschuh wrote:
> > The ChromeOS EC used in Framework laptops supports the standard cros
> > keyboard backlight protocol.
> > However the firmware on these laptops don't implement the ACPI ID
> > GOOG0002 that is recognized by cros_kbd_led_backlight and they also
> > don't use device tree.
>
> Something I'd wonder is if the GOOG0002 ACPI ID can go away entirely with
> this type of change. Presumably the Chromebooks with ChromeOS EC /also/
> advertise EC_FEATURE_PWM_KEYB.
Sounds good to me in general. It would make the code cleaner.
But I have no idea how CrOS kernels are set up in general.
If they are not using CONFIG_MFD_CROS_EC_DEV for some reason that
wouldn't work.
If the CrOS folks agree with that aproach I'll be happy to implement it.
> <snip>
Thomas
next prev parent reply other threads:[~2024-05-06 17:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 9:41 [PATCH] platform/chrome: cros_kbd_led_backlight: enable probing through EC_FEATURE_PWM_KEYB Thomas Weißschuh
2024-05-05 13:42 ` Mario Limonciello
2024-05-06 17:38 ` Thomas Weißschuh [this message]
2024-05-09 4:25 ` Tzung-Bi Shih
2024-05-09 8:13 ` Thomas Weißschuh
2024-05-09 9:28 ` Tzung-Bi Shih
2024-05-05 21:08 ` kernel test robot
2024-05-05 22:33 ` kernel test robot
2024-05-05 22:44 ` kernel test robot
2024-05-07 8:29 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae29f036-5e39-47ee-98d3-c023a263a3ef@t-8ch.de \
--to=linux@weissschuh.net \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dustin@howett.net \
--cc=groeck@chromium.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox