From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F4A33876BF for ; Mon, 20 Apr 2026 20:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776718672; cv=none; b=NrJrbudq+6ETg3kzqFkYgtbEQQ3p+h0FnGWTfNa6s+43L9ZbOQ8fOhG9tOqB1STmnV7DiTLu/TiCIysW8WjdBEgUA+LNqObfeQtSx7+ZkLB+NuqMw4ISme6Nd+lYBrk0KdfFag8A5HjuMVlrjdWqRLhchl4ognGH2TQsdSR//80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776718672; c=relaxed/simple; bh=ulA/E3omBV0/ANHTKXtHQdfXIzWGQ3Qsywuk4gNKI20=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HnYgq8kz8n94xqIMGihIt+TER2F45MdsF2c+td0ssJ76KTLLCXr21+S5c9Cjp0AUCcvyEk5693qpH8THwlmGnDKam1zjjcqma2Me8tnT3RjQanDNZVgiEwjGlcjtkwRFIkg6Xkwm9zYu7dadtEjcTvjaJ6jSDhbsrXOl3lcHTlM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=JLprDcHv; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JLprDcHv" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-12c55e3858cso8840441c88.0 for ; Mon, 20 Apr 2026 13:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1776718668; x=1777323468; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=UJTy7ISgMbSZNylSWRqrfmNeCOG0G9Vq8ABg0zDPRJQ=; b=JLprDcHvC5MbhtKA/uERToJ8VGjcPwqNfJW5G4sE9lUYF77t3Vbm/dehqvzl1pdfms EHcvsgKeLWHMj1b9iuy6cTIwzEElJMe61FRwEP7LifbfJSCGkoFRQ/dCv9Xr3XqdkJFj Ol9ReOE4yt+CTV1EX2+alifFt4s1QOV7pB28k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776718668; x=1777323468; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UJTy7ISgMbSZNylSWRqrfmNeCOG0G9Vq8ABg0zDPRJQ=; b=dJzGAGLlXGDQiDjmzMS+7pVGnOHzTm2QC6AMsSydtGrOq1uwTae3wv5ssknXBBcbAI iaU8xrcPE9ky5De9YQHnvjZVOvr++2OqxADeUFKkBmErUxyjW1aD3O2VYUerga6I6tUc YZNe5Qy/aaPudt5iF5HRm4YPAtFhgA3hDyHotGEPskF14WGyhUryMJwrHNDNpAuAqUUf IXKRT7V2FymA+tttZx9GnUkicryVzBNz73+e2mCIyXMvW/xVGCTtH6+qGdSo8dXS9AlI aWBULIKbUbyLaVBH1U9jEls+rG+GBOr5o2pgcYFqdy7hE+myfYH4T2gFFsC7QxthwD2W vPRw== X-Forwarded-Encrypted: i=1; AFNElJ8iDwNMWH2GB5BeO6Xq09yrwFlL0UCgi8GmueUVDx04If1oGO103tECd7k7QYEg6iDj7fJPznTXquMl6NDXWGI=@lists.linux.dev X-Gm-Message-State: AOJu0Yzc4SkvvPcZzJx+NhXtOrGUgxyi0XTAcIj8H6d2ngcgkP5dznHl +jZX0/IXEiEWWmpi+BMYZV29YDjiWuJY1xfJ61/nZolNuTGCh0q9qSXl45Bsg4T2/A== X-Gm-Gg: AeBDietVoGAIItGi8Yh4tY46InK6LUSTAAD+yY0Lq+M+f0tX78tJzxk9lAPow8wyDVy FjGoQV3XskTcxkJjBYtXRPhSnX6oYseKZa98t+ingznOJRfbgulkaKhnsFt66hLEcwn7bM1ISmZ 4dx/LHKrSlUzkegR0U37ZtLy4bIkWaPszB9tACNYmbCN5rUmfSKc3Xt+mTbWuIMotAlHECq9dR/ kgeVuk/hr/NjmSm7lfCgvjRpJ+e4acL0NSBpQ/aJKADQ5OFpDnjqPiL2UKFhMekUuTU2xjV26VR GQJCzXuxIWH9xaHdNLate1p2F9IvCqhHFsWnplCFKvp/RuGBo5UarA1HP8j61UJLFj5egyPtSBN XPcw1H+X0VutnnImT6ony1HjmcsjH1otslSm1rAatq/ey/DgzGgawQJ5svF+0p80TDgQSmLVH4z EMwWQtXmp5tBg3/IsbHZIfQVUTZObpznEl3aP2tIm3u+M18X/9v1Rpts8k+EqYMgeDiY/2LSXn X-Received: by 2002:a05:7022:513:b0:12a:94ab:e20 with SMTP id a92af1059eb24-12c73f930cemr8621290c88.20.1776718668238; Mon, 20 Apr 2026 13:57:48 -0700 (PDT) Received: from localhost ([2a00:79e0:2e7c:8:b635:62cc:359d:682d]) by smtp.gmail.com with UTF8SMTPSA id a92af1059eb24-12c74a20b9csm16321311c88.12.2026.04.20.13.57.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 13:57:47 -0700 (PDT) Date: Mon, 20 Apr 2026 13:57:45 -0700 From: Brian Norris To: Rob Herring Cc: Chen-Yu Tsai , Sasha Levin , Krzysztof Kozlowski , AngeloGioacchino Del Regno , Linus Torvalds , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Matthias Brugger , Doug Anderson , Julius Werner , chrome-platform@lists.linux.dev Subject: Re: [regression] of: mis-parsing Depthcharge's /firmware Message-ID: References: <936bf452-3d1f-4940-9a91-69efcdc6985e@collabora.com> <19ba4910-f909-41b4-ba62-c904bc37d41d@linaro.org> <20241209092809.GA3246424@google.com> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Rob, On Mon, Apr 20, 2026 at 07:57:40AM -0500, Rob Herring wrote: > On Fri, Apr 17, 2026 at 4:26 PM Brian Norris wrote: > > > > Hi all, > > > > (New subject; was "Re: [GIT PULL] Devicetree updates for v6.13") > > > > On Mon, Dec 09, 2024 at 05:28:09PM +0800, Chen-Yu Tsai wrote: > > > steelix.dtb is the same, plus the firmware now inserts #address-cells > > > and #size-cells under /firmware. This fix has landed for all future > > > ChromeOS devices via our main firmware branch [1]. > > > > > > AFAIK they also have a bad FDT END symbol. This was only recently > > > discovered and fixed for future devices [2]. > > > > > > > > > ChenYu > > > > > > [1] Gerrit: https://crrev.com/c/6051580 > > > [2] Gerrit: https://review.coreboot.org/c/coreboot/+/85462 > > > > This all comes back to bite us, since nobody went back to patch the > > existing Chromebook device trees, and now we've added a true regression > > on top: > > > > In commit 6e5773d52f4a ("of/address: Fix WARN when attempting > > translating non-translatable addresses") we now reject devices without > > '#address-cells', and this breaks the DTs generated by bootloaders > > without Chen-Yu's https://crrev.com/c/6051580 fix (this is ... pretty > > much all Chromebooks). Specifically, Linux now refuses to add 'reg' > > resources to the /firmware/coreboot device, and we fail with: > > > > [ 11.886271] coreboot_table firmware:coreboot: probe with driver coreboot_table failed with error -22 > > > > This is almost certainly a DTB ABI regression. > > > > This was noticed here (OpenWrt supports some Chromium-based WiFi routers > > that use Depthcharge-based bootloaders from many years ago): > > > > https://github.com/openwrt/openwrt/issues/21243 > > > > For now, I just patched up the OpenWrt DTS files like so: > > https://github.com/openwrt/openwrt/pull/22951 > > > > But what should we do going forward? I note that Rob says "We may > > revisit this later and address with a fixup to the DT itself" in commit > > 8600058ba28a ("of: Add coreboot firmware to excluded default cells > > list"). > > > > That never happened, and a ton of Chromium devices are still broken. > > The above just silenced the warning. If they are broken, then > something else broke them. Right. To be clear, the regression is in commit 6e5773d52f4a, not 8600058ba28a. But 8600058ba28a (and this thread I'm replying to): (a) started the precedent of treating this known-problemtatic DT pattern specially; (b) started to consider "fixing" those old DTs (but notably, not reliably/proactively -- even if Google updates official bootloaders, many devices are far out of Google support; or even if supported, don't have a systematic way of receiving Google-provided updates because they run non-Google software); and (c) because (a)/(b) hid the problem partially, it was less noticeable that commit 6e5773d52f4a *really* broke things a month later, in the last days of the v6.13 cycle. (Official Google testing probably didn't notice, because they only tested devices with the latest Google bootloaders. Only people with old bootloaders / non-Google software noticed.) > > (They don't have WARNINGs, but /sys/firmware/vpd, etc., is still > > missing.) > > > > Can we patch of_bus_default_match() to accept an empty 'ranges' [1]? Or > > should I go patch every Chromium-device DTS file I can find? So far, I > > think I can get that done in 17 files in the upstream tree... > > Both. To be clear, my options were: 1. fix up kernel parsing to accept these /firmware/coreboot node structures (with empty ranges / no #{address,size}-cells) 2. add #{address,size}-cells into the kernel-included dts(i) files (this will merge safely with the DTB modifications patched in by old bootloaders). I wouldn't call #2 "kernel fixup the DT", personally. I'd call it "fix up the DT source that happens to be provided by the kernel." This assumes no one is using device trees that are exclusively maintained outside the kernel. (I believe that's generally true, except for OpenWrt. And even there, it's still acceptable to patch the DT source, and I've already done so.) > Though I'd rather the kernel fixup the DT rather than relax the > parsing code for everyone. Then we know what platforms need this and > don't let new ones in. I'm not sure how to parse this. This paragraph sounds like a 3rd option: 3. "kernel fixup the DT" -- sound like you want the kernel to identify these specific /firmware/coreboot structures, and activtly modify/patch the FDT at runtime Is that an accurate interpretation? If so, that sounds rather novel, and nothing like "both" (#1 + #2 above). It's certainly possible, but seems like a large lift for this particular incompatibility. So I assume you actually meant something else, possibly a clarification or narrowing of #1 or #2. Can you help un-confuse me on what you think the best route or routes are? Brian