From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH] power: supply: cros_peripheral_charger: unregister EC notifier
Date: Tue, 16 Jun 2026 05:59:38 +0000 [thread overview]
Message-ID: <ajDmSuK-eahNO1xu@google.com> (raw)
In-Reply-To: <20260615063105.39152-1-pengpeng@iscas.ac.cn>
On Mon, Jun 15, 2026 at 02:31:05PM +0800, Pengpeng Hou wrote:
> cros_pchg_probe() registers an EC event notifier whose callback uses the
> devm-allocated charger_data via container_of(). The driver has no
> remove callback and does not unregister the notifier, so the notifier
> chain can retain a pointer to freed driver state after unbind or probe
> cleanup.
>
> Register a devm cleanup action immediately after the notifier is
> installed so the notifier is unregistered before the driver state is
> released. Also fail probe if the notifier cannot be registered, instead
> of leaving a charger device that cannot receive EC events.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
A possible nit is to use s/cros_peripheral_charger/cros_pchg/ in the patch
subject to leave more space for the summary.
With or without this,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
prev parent reply other threads:[~2026-06-16 5:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 6:31 [PATCH] power: supply: cros_peripheral_charger: unregister EC notifier Pengpeng Hou
2026-06-16 5:59 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajDmSuK-eahNO1xu@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pengpeng@iscas.ac.cn \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox