Chrome platform driver development
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Benson Leung <bleung@chromium.org>
Cc: Bryam Vargas <hexlabsecurity@proton.me>,
	chrome-platform@lists.linux.dev, tfiga@chromium.org,
	suleiman@chromium.org
Subject: Re: [PATCH] platform/chrome: sensorhub: Fix dropped timestamp events and log spam
Date: Tue, 14 Jul 2026 11:54:57 +0000	[thread overview]
Message-ID: <alYjkXZGWNvvwnct@google.com> (raw)
In-Reply-To: <20260714065202.3248017-1-tzungbi@kernel.org>

On Tue, Jul 14, 2026 at 06:52:02AM +0000, Tzung-Bi Shih wrote:
> Commit 833740a2333c ("platform/chrome: sensorhub: Bound the EC-reported
> sensor number") evaluated the `sensor_num` against the bounds limit even
> for timestamp events.  A timestamp event typically has a `sensor_num` of
> 0xff [1], causing the driver to flag it as invalid and skip to the next
> event.
> 
> As a result, we'd see a flooding of "Invalid sensor number 255 from EC"
> warning logs and these timestamp events were being dropped.
> 
> Additionally, the firmware only ORs the tablet mode flag [2] onto
> timestamp events.  Because the firmware strictly generates standalone
> timestamps (without other flags like ODR or FLUSH), bypassing the bounds
> check for anything containing the TIMESTAMP flag is safe and avoids
> invalid array access.
> 
> Skip the bounds check for events carrying the
> MOTIONSENSE_SENSOR_FLAG_TIMESTAMP flag.

Please disregard the patch.  We found this just opens another door for
malfunctioned or compromised firmware to access the array `batch_state`
out of bound.  Will fix it in v2.

      reply	other threads:[~2026-07-14 11:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14  6:52 [PATCH] platform/chrome: sensorhub: Fix dropped timestamp events and log spam Tzung-Bi Shih
2026-07-14 11:54 ` Tzung-Bi Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alYjkXZGWNvvwnct@google.com \
    --to=tzungbi@kernel.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=hexlabsecurity@proton.me \
    --cc=suleiman@chromium.org \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox