From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Hongyan Xu <getshell@seu.edu.cn>
Cc: bleung@chromium.org, groeck@chromium.org,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
jianhao.xu@seu.edu.cn
Subject: Re: [PATCH] platform/chrome: cros_ec_debugfs: unregister panic notifier
Date: Wed, 29 Jul 2026 03:39:33 +0000 [thread overview]
Message-ID: <aml19Q7Zj-Q8f_Se@google.com> (raw)
In-Reply-To: <20260728123423.781-3-getshell@seu.edu.cn>
On Tue, Jul 28, 2026 at 08:33:37PM +0800, Hongyan Xu wrote:
> Unregister the notifier before tearing down debugfs state. Also run the
> console-log cleanup in the probe error path.
Thanks for looking into this. This should separate into 2 patches: 1 for
cros_ec_cleanup_console_log() and 1 for blocking_notifier_chain_unregister().
> @@ -534,6 +534,7 @@ static int cros_ec_debugfs_probe(struct platform_device *pd)
> return 0;
>
> remove_debugfs:
> + cros_ec_cleanup_console_log(debug_info);
It can be called even if cros_ec_create_console_log() isn't called. It's
harmless because cros_ec_cleanup_console_log() checks
`debug_info->log_buffer.buf`.
To be clear, I'd prefer to introduce a new goto label for fixing it.
prev parent reply other threads:[~2026-07-29 3:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 12:33 [PATCH] platform/chrome: cros_ec_debugfs: unregister panic notifier Hongyan Xu
2026-07-29 3:39 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aml19Q7Zj-Q8f_Se@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=getshell@seu.edu.cn \
--cc=groeck@chromium.org \
--cc=jianhao.xu@seu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox