From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Andrei Kuchynski <akuchynski@chromium.org>
Cc: Jameson Thies <jthies@google.com>,
Benson Leung <bleung@chromium.org>,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] platform/chrome: cros_ec_typec: Enforce priority-based mode selection
Date: Thu, 15 Oct 2026 12:15:17 +0000 [thread overview]
Message-ID: <atDD1RHZylPRZtP8@google.com> (raw)
In-Reply-To: <20261008134056.3816556-2-akuchynski@chromium.org>
On Thu, Oct 08, 2026 at 01:40:55PM +0000, Andrei Kuchynski wrote:
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
...
> +/* Delay between mode entry/exit attempts, ms */
> +static const unsigned int mode_selection_delay = 1000;
> +/* Timeout for a mode entry attempt, ms */
> +static const unsigned int mode_selection_timeout = 4000;
Couldn't they be macros?
> @@ -421,7 +427,6 @@ static int cros_typec_register_port_altmodes(struct cros_typec_data *typec,
> memset(&desc, 0, sizeof(desc));
> desc.svid = USB_TYPEC_TBT_SID;
> desc.mode = TBT_MODE;
> - desc.inactive = true;
Why this is removed? Per 1aede0698167 ("platform/chrome: cros_ec_typec:
Disable tbt on port"), it disables entering TBT mode automatically.
> @@ -940,6 +952,31 @@ static int cros_typec_register_altmodes(struct cros_typec_data *typec, int port_
> goto err_cleanup;
> }
>
> + /* Once all partner alt-modes are added, we should also trigger
> + * mode selection.
> + */
For multiple line comments:
/*
* Once ...
> + if (is_partner && typec->ap_driven_altmode) {
> + bool usb4_mode = (port->caps.usb_capability & USB_CAPABILITY_USB4) &&
> + (PD_VDO_UFP_DEVCAP(port->p_identity.vdo[0]) & DEV_USB4_CAPABLE);
> +
> + if (usb4_mode) {
> + ret = cros_typec_enter_usb_mode(port->port, USB_MODE_USB4);
> + if (ret < 0) {
> + usb4_mode = false;
> + dev_err(typec->dev,
> + "Unable to activate USB4 mode, port: %d\n", port_num);
> + }
> + }
> + if (!usb4_mode) {
> + ret = typec_mode_selection_start(port->partner,
> + mode_selection_delay,
> + mode_selection_timeout);
> + if (ret < 0)
> + dev_err(typec->dev,
> + "Unable to run mode selection, port: %d\n", port_num);
Wouldn't it need to go to err_cleanup and return the ret? Or, if they
aren't considered as errors, dev_warn().
> diff --git a/drivers/platform/chrome/cros_typec_altmode.c b/drivers/platform/chrome/cros_typec_altmode.c
> index 66c546bf89b53..116329dd113f8 100644
> --- a/drivers/platform/chrome/cros_typec_altmode.c
> +++ b/drivers/platform/chrome/cros_typec_altmode.c
> @@ -41,12 +41,16 @@ static void cros_typec_altmode_work(struct work_struct *work)
> {
> struct cros_typec_altmode_data *data =
> container_of(work, struct cros_typec_altmode_data, work);
> + int ret;
>
> mutex_lock(&data->lock);
>
> - if (typec_altmode_vdm(data->alt, data->header, data->vdo_data,
> - data->vdo_size))
> + ret = typec_altmode_vdm(data->alt, data->header, data->vdo_data,
> + data->vdo_size);
> + if (ret) {
> dev_err(&data->alt->dev, "VDM 0x%x failed\n", data->header);
> + typec_altmode_state_update(data->port->partner, data->sid, ret);
> + }
Wouldn't it need to update the state even if !ret?
next prev parent reply other threads:[~2026-10-15 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 13:40 [PATCH v2 0/2] USB Type-C mode selection Andrei Kuchynski
2026-10-08 13:40 ` [PATCH v2 1/2] platform/chrome: cros_ec_typec: Enforce priority-based " Andrei Kuchynski
2026-10-15 12:15 ` Tzung-Bi Shih [this message]
2026-10-08 13:40 ` [PATCH v2 2/2] platform/chrome: cros_ec_typec: Reorder altmode registration Andrei Kuchynski
2026-10-15 12:14 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atDD1RHZylPRZtP8@google.com \
--to=tzungbi@kernel.org \
--cc=abhishekpandit@chromium.org \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox