From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2F7913B585 for ; Wed, 27 Mar 2024 13:32:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711546335; cv=none; b=tYqXuXP67vbjGDKXzIcMSM4Vq1fHZ6qJ3r7QlK1uGaJZ7w4kgUSXr3GnNmYALF+dRFu1kIhirT+1Wk0DqdJ3kY6gQgewZawpNbB5DoquJrMf3kbw1syo5hIA1EIViBcGM9hyoHqTjJZzPrIMYqYejjJLHjrT5Q5Q0J5MamYSapc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711546335; c=relaxed/simple; bh=K0UVZINUhSSLxdNU4wwBE/T+FEz46ODAQKkZL3ADYrU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GTC3M5QaeXMeQ+OtYLTrAgw4OWLHvZY0AM8tY/42oEl84rLvI9DVfUy9+9NbDUJQACKWLyXCzR7CQ3BJyB0am5AUr9vysQGr4RcHYZRzXpo/DwDcX8OvlsZxQ9rJsj/KXs1oalmjqDkocJxoQX7RRF2YxMsu9DehWIArOfQLyTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=df/7DgX4; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="df/7DgX4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711546331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jD3Utmle+bis7mmdPw9AquqAmC1o8mQyHmUQiw/WEzk=; b=df/7DgX4aTiAuA+JAj2tG6lVWAV68slnmgNzVKrmQG6jhUh5Mx53DO1djxuzUqoIoJpRdZ DVmQJYFXTw/OSV//gs0x/8prhF6ZiHRlt3C6ylvTQRvk+SEmlP8UhagE6HY5f5PDqyBj04 DKQLnAFR3HLLDoNeoNE6D0kI3MuMWrk= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-97-7cpdLA1QOqWlqesSjsvQmQ-1; Wed, 27 Mar 2024 09:32:10 -0400 X-MC-Unique: 7cpdLA1QOqWlqesSjsvQmQ-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a45acc7f07cso375503066b.2 for ; Wed, 27 Mar 2024 06:32:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711546329; x=1712151129; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jD3Utmle+bis7mmdPw9AquqAmC1o8mQyHmUQiw/WEzk=; b=bBKWfGdJrPjeQtoaUBkAS0HPjcGohTO/9i936m2XIUpxleSWsSstgWvurz21Opg1G4 qjKWSI8mbyUM7sPm2xvwcZaxg8ofil1ZupTIWgLPbCFtBBV6wPhWAbZzzPj3f70WhLax Us1Z9Rhreb0/DGV3usJsSwFZF0Tj0DUpLgOAukYCnPmgtoZATehowJ59lSkZgYWCgl6D iXVdx9B0fVWMSbG6e3AsQo0E/irmmp5xV7HJI69I0e53ryk4jgS2QgVOv7CQh7UHVc0K 2InxcgVKuOo9DdBPHk3jeIOWxRcm8hZEjA7c7ntCeZWHobXo4UAswUV+SqvUEdAJS38H xJUg== X-Forwarded-Encrypted: i=1; AJvYcCWu8UHc/myQI9ENQQf+MOSSAmd3CKm0z19EPwChaOrQksXOx+088ql2HRubh8Q+8VIK7By0V/XMfr0eYtC3nqu5Yjg+RuWvjPh0Q34HOphs X-Gm-Message-State: AOJu0Yz1+OUqXUIkrnbcUT1SC25LpqAbyC5/NhzgTDOfW4uHWm51XOip eXqusgMec1Xjw7Y9pdO3lGwViXiDqi4mKdahQL1mxAG7gGZW2LnbcbQgP40HWQFII09YqFfyCdW Xj3XxQPshewvalxpAkzvjc2h7lB5UMcxHrhRZ6Z+lFGXdoCjyKpYSaQNjbzkbgqbluQ== X-Received: by 2002:a17:907:7206:b0:a4d:fe2f:a70b with SMTP id dr6-20020a170907720600b00a4dfe2fa70bmr2448979ejc.41.1711546329062; Wed, 27 Mar 2024 06:32:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGdhqFLAf1gKN0Y/NZQvk+kIH5rUrJ00j88K5l/PrX7PEX8pYP+EIH8Lg2tXiyjUb+BEqFQQ== X-Received: by 2002:a17:907:7206:b0:a4d:fe2f:a70b with SMTP id dr6-20020a170907720600b00a4dfe2fa70bmr2448827ejc.41.1711546326567; Wed, 27 Mar 2024 06:32:06 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id q2-20020a1709060e4200b00a4674ad8ab9sm5383406eji.211.2024.03.27.06.32.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 06:32:06 -0700 (PDT) Message-ID: Date: Wed, 27 Mar 2024 14:32:05 +0100 Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/19] ACPI: store owner from modules with acpi_bus_register_driver() To: "Rafael J. Wysocki" , Krzysztof Kozlowski Cc: Len Brown , Robert Moore , Dmitry Torokhov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Benson Leung , Tzung-Bi Shih , Corentin Chary , "Luke D. Jones" , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Thadeu Lima de Souza Cascardo , Daniel Oliveira Nascimento , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Matan Ziv-Av , Mattia Dongili , Azael Avalos , Richard Cochran , Jeff Sipek , Ajay Kaher , Alexey Makhalov , VMware PV-Drivers Reviewers , Theodore Ts'o , "Jason A. Donenfeld" , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linux.dev, linux-input@vger.kernel.org, netdev@vger.kernel.org, chrome-platform@lists.linux.dev, platform-driver-x86@vger.kernel.org References: <20240327-b4-module-owner-acpi-v1-0-725241a2d224@linaro.org> From: Hans de Goede In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, On 3/27/24 2:16 PM, Rafael J. Wysocki wrote: > On Wed, Mar 27, 2024 at 8:44 AM Krzysztof Kozlowski > wrote: >> >> Merging >> ======= >> All further patches depend on the first amba patch, therefore please ack >> and this should go via one tree: ACPI? >> >> Description >> =========== >> Modules registering driver with acpi_bus_register_driver() often forget to >> set .owner field. >> >> Solve the problem by moving this task away from the drivers to the core >> amba bus code, just like we did for platform_driver in commit >> 9447057eaff8 ("platform_device: use a macro instead of >> platform_driver_register"). >> >> Best regards, >> Krzysztof >> >> --- >> Krzysztof Kozlowski (19): >> ACPI: store owner from modules with acpi_bus_register_driver() >> Input: atlas: - drop owner assignment >> net: fjes: drop owner assignment >> platform: chrome: drop owner assignment >> platform: asus-laptop: drop owner assignment >> platform: classmate-laptop: drop owner assignment >> platform/x86/dell: drop owner assignment >> platform/x86/eeepc: drop owner assignment >> platform/x86/intel/rst: drop owner assignment >> platform/x86/intel/smartconnect: drop owner assignment >> platform/x86/lg-laptop: drop owner assignment >> platform/x86/sony-laptop: drop owner assignment >> platform/x86/toshiba_acpi: drop owner assignment >> platform/x86/toshiba_bluetooth: drop owner assignment >> platform/x86/toshiba_haps: drop owner assignment >> platform/x86/wireless-hotkey: drop owner assignment >> ptp: vmw: drop owner assignment >> virt: vmgenid: drop owner assignment >> ACPI: drop redundant owner from acpi_driver > > I definitely like this, so > > Acked-by: Rafael J. Wysocki > > for the series and I can pick it up if people agree. Thanks all the drivers/platform/x86/* change look good to me: Acked-by: Hans de Goede And I'm fine with merging these through the linux-pm / ACPI tree. Regards, Hans