From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A30257A for ; Fri, 10 Jun 2022 19:51:19 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id me5so47440ejb.2 for ; Fri, 10 Jun 2022 12:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=bNY4bb5ZsDGbijlscX/zWHp76bvVhoKTJQjCK2gLBow=; b=DTARzN9ZKxLbpM5DnF604iI8/F/84/wIKw08CbQfw05YnVX88YGW6HVfBxQNHvMu4T MLrV3I1t6KM5Qc6HlnyeXHSTGoq8+8DaWtqoRUwsLbX6Mzc8EpX122ha3qRBRoFfEqzN Jk0f/3X9FLtgjhjaqJKanWVijWyNNRgDw6pmj5+2xfApIvc2SRAwOjLitceTonJ4eGE1 a1A9wbvVgJFRqD/0S50YXqjQh+yziCS7x5lzFW9SKapPD3uUc9it44OjhImJd8j2+oZt Butz14g0HcCbwqNDkTuGrH/EVS+NkDJB41ZnGmOfym00EegEpO7qNAqhl52gA+RezkJc GTxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=bNY4bb5ZsDGbijlscX/zWHp76bvVhoKTJQjCK2gLBow=; b=nyCepq+g62kUq6rk9K0FfTzB9R/iNS1+V7fYzUV6o+G57j56LAqbMkoDicrD0ZwYfF m01eGRRM1rs0qvC6P/Te/9DTRAu4JWp8G6diY6VlxzKBDPopdwpN1FhmHeF+QGW58VBD QMp8fsB/K4MdE/cnZqsvhh1sb0WgzUYbUs3iRNZp/E1zMr36NFcQpNbP6Y+s+PVFILZ1 EU7FlkEaMvd7NaFSTDDIxrTrwtFKZIqFJ+jQngVa3DtbaUUORwhuwFhddBTIWFWiORB5 MDpDPC71lDl7vbxaGlFLAL3S0DD40Cltp1uYGQxk4hMPSR0T/+EABB/3QxVkN7DnQ60Y gsiw== X-Gm-Message-State: AOAM5318BFiBPpN5nB6IKyHei4qriypmaZz/q2zvmd5cQSoFWNPn+t9M oZOiGQFKiDAHAj+4J9TenGg= X-Google-Smtp-Source: ABdhPJxHRykgXinV3uoaEPm9Ud4a9M4gnh2v3qf5U98udrI7NhTVLe93fDw1Gnx05NF5PsnFjGIIwQ== X-Received: by 2002:a17:906:51d6:b0:712:c9:8a1b with SMTP id v22-20020a17090651d600b0071200c98a1bmr10665567ejk.656.1654890677793; Fri, 10 Jun 2022 12:51:17 -0700 (PDT) Received: from ?IPv6:2001:a61:136e:3c01:8bd4:cf6f:76f1:a861? ([2001:a61:136e:3c01:8bd4:cf6f:76f1:a861]) by smtp.gmail.com with ESMTPSA id ck16-20020a170906c45000b006feb20b5235sm12715703ejb.84.2022.06.10.12.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 12:51:17 -0700 (PDT) Message-ID: Subject: Re: [PATCH 34/34] iio: inkern: fix coding style warnings From: Nuno =?ISO-8859-1?Q?S=E1?= To: Joe Simmons-Talbott , Nuno =?ISO-8859-1?Q?S=E1?= Cc: linux-imx@nxp.com, linux-renesas-soc@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, Lad Prabhakar , linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, openbmc@lists.ozlabs.org, Cai Huoqing , Benjamin Fair , Jishnu Prakash , Linus Walleij , Lars-Peter Clausen , Alexandre Torgue , Amit Kucheria , Andy Gross , Michael Hennerich , Haibo Chen , Benson Leung , "Rafael J. Wysocki" , Alexandre Belloni , Christophe Branchereau , Patrick Venture , Arnd Bergmann , Nancy Yuen , Sascha Hauer , Daniel Lezcano , Gwendal Grignou , Saravanan Sekar , Tali Perry , Maxime Coquelin , Paul Cercueil , Thara Gopinath , Avi Fishman , Lorenzo Bianconi , Claudiu Beznea , Pengutronix Kernel Team , Andy Shevchenko , Fabrice Gasnier , Matthias Brugger , Tomer Maimon , Bjorn Andersson , Nicolas Ferre , Jonathan Cameron , Zhang Rui , Shawn Guo , Guenter Roeck , Fabio Estevam , Olivier Moysan , Eugen Hristev , Miquel Raynal Date: Fri, 10 Jun 2022 21:51:15 +0200 In-Reply-To: References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-35-nuno.sa@analog.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, 2022-06-10 at 11:53 -0400, Joe Simmons-Talbott wrote: > On Fri, Jun 10, 2022 at 10:45:45AM +0200, Nuno Sá wrote: > > Just cosmetics. No functional change intended... > > > > Signed-off-by: Nuno Sá > > --- > >  drivers/iio/inkern.c | 64 ++++++++++++++++++++++------------------ > > ---- > >  1 file changed, 32 insertions(+), 32 deletions(-) > > > > diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c > > index 7eb536560ded..526519cefcb9 100644 > > --- a/drivers/iio/inkern.c > > +++ b/drivers/iio/inkern.c > > @@ -45,13 +45,13 @@ int iio_map_array_register(struct iio_dev > > *indio_dev, struct iio_map *maps) > >         int i = 0, ret = 0; > >         struct iio_map_internal *mapi; > >   > > -       if (maps == NULL) > > +       if (!maps) > >                 return 0; > >   > >         mutex_lock(&iio_map_list_lock); > > -       while (maps[i].consumer_dev_name != NULL) { > > +       while (!maps[i].consumer_dev_name) { > > Shouldn't this be?: > while (maps[i].consumer_dev_name) { > Ups... Nice catch! I was probably in bot mode already. - Nuno Sá