Chrome platform driver development
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Lukasz Majczak <lma@chromium.org>,
	Gwendal Grignou <gwendal@chromium.org>,
	Tzung-Bi Shih <tzungbi@kernel.org>,
	Radoslaw Biernacki <biernacki@google.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	chrome-platform@lists.linux.dev
Subject: Re: [PATCH v3 0/3] Introduce EC-based watchdog
Date: Fri, 19 Jan 2024 04:50:09 -0800	[thread overview]
Message-ID: <d2329494-2c57-41bb-a9ea-2c9903500d1e@roeck-us.net> (raw)
In-Reply-To: <20240119084328.3135503-1-lma@chromium.org>

On 1/19/24 00:43, Lukasz Majczak wrote:
> Chromeos devices are equipped with the embedded controller (EC)
> that can be used as a watchdog. The following patches
> updates the structures and definitions required to
> communicate with EC-based watchdog and implements the
> driver itself.
> 
> The previous version of this patch was sent here:
> https://patchwork.kernel.org/project/linux-watchdog/list/?series=817925
> 
> Changelog
> V2->V3:
> * drop "-drv" from driver name
> * use format #define<space>NAME<tab>value
> 

I am a bit lost here. You dropped my Reviewed-by: tags, even though
I specifically said that they applied with those changes made.
Also, according to the above patch 1/3 was not changed at all.

What else did you change that warrants dropping the tags ?

Guenter


  parent reply	other threads:[~2024-01-19 12:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19  8:43 [PATCH v3 0/3] Introduce EC-based watchdog Lukasz Majczak
2024-01-19  8:43 ` [PATCH v3 1/3] platform/chrome: Update binary interface for " Lukasz Majczak
2024-01-19  8:43 ` [PATCH v3 2/3] watchdog: Add ChromeOS EC-based watchdog driver Lukasz Majczak
2024-01-22 10:31   ` Krzysztof Kozlowski
2024-01-22 15:09     ` Łukasz Majczak
2024-01-19  8:43 ` [PATCH v3 3/3] mfd: cros_ec: Register EC-based watchdog subdevice Lukasz Majczak
2024-01-25 13:37   ` (subset) " Lee Jones
2024-01-25 13:55     ` Łukasz Majczak
2024-01-26  9:07       ` Lee Jones
2024-01-19 12:50 ` Guenter Roeck [this message]
2024-01-19 14:10   ` [PATCH v3 0/3] Introduce EC-based watchdog Łukasz Majczak
2024-01-19 14:42     ` Guenter Roeck
2024-01-19 14:50       ` Łukasz Majczak
2024-01-19 15:10         ` Łukasz Majczak
2024-03-25  1:54 ` patchwork-bot+chrome-platform
2024-03-25  2:13 ` patchwork-bot+chrome-platform

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2329494-2c57-41bb-a9ea-2c9903500d1e@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=biernacki@google.com \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=groeck@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=krzk@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=lma@chromium.org \
    --cc=tzungbi@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox