From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sung-Chi Li <lschyi@chromium.org>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Sebastian Reichel <sre@kernel.org>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: chrome-platform@lists.linux.dev, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: mfd: cros-ec: add properties for thermal cooling cells
Date: Mon, 25 Nov 2024 09:45:12 +0100 [thread overview]
Message-ID: <e3b8e581-957e-48ef-8769-13a5b0667490@kernel.org> (raw)
In-Reply-To: <20241125-extend_power_limit-v2-2-c3266a86e9b1@chromium.org>
On 25/11/2024 09:31, Sung-Chi Li wrote:
> A charger chip is connect to the ChromeOS Embedded Controller (EC).
> When external power input into the system, current would go through the
> charger chip, generating heat in the system. The EC supports limiting
> the input current, thus reducing the generated heat. As a result, EC is
> a simulated passive cooling device.
EC is not part of the SoC, therefore this is not a cooling device. It is
not thermal sensor either, but this you pushed before I could object.
>
> We cannot reuse the existing charge managing mechanism in the power
> framework due to:
>
> - The power framework requires the charger to expose its thermal status,
> which is not a supported functionality on EC.
Fix power framework then.
> - We need to use different thermal sensors to run thermal control,
> rather than using thermal sensor on the charger.
Nothing stops you from using thermal sensors or thermal control. Still,
this is not part of SoC, this is not thermal zone and this is not a SoC
cooling device.
NAK
Best regards,
Krzysztof
prev parent reply other threads:[~2024-11-25 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 8:31 [PATCH v2 0/2] Extend the cros_usbpd-charger to make it a passive thermal cooling device Sung-Chi Li
2024-11-25 8:31 ` [PATCH v2 1/2] power: supply: cros_usbpd-charger: extend as a thermal of " Sung-Chi Li
2024-11-25 8:31 ` [PATCH v2 2/2] dt-bindings: mfd: cros-ec: add properties for thermal cooling cells Sung-Chi Li
2024-11-25 8:45 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3b8e581-957e-48ef-8769-13a5b0667490@kernel.org \
--to=krzk@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lschyi@chromium.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox