From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A351C9EC6 for ; Thu, 31 Oct 2024 16:27:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730392072; cv=none; b=srqvZiwGkdkpvpZjKDwMM3lO2/IHhIvpn5D4kHsTuVcHi5kyIEXlioyToBYD4nIJAXxeJnKJwcPnTHKIrixMxREAKxtoNB+zXbyZQ3mQqGF/g1EGGlY4jQPrGMlpVXcEhhkIolLCnWn6/1LZIEaoHvpha14PaIRZXh/o86QohF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730392072; c=relaxed/simple; bh=NXkq/qyOqhp8iiSocyYd5F4iMl9dEpzBnig3MAjD1ws=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jTb4TbSaDZXmB9zPUKtdRe70vkp4IvTKjmaLizeoAWYthwYBUGnNEJdwrYvkZbZzxHtEVaEZiZsEtIQUHO1A41NGwWGaJFKgqjfuIWxLLR05QRS7yZ0kJCUXa8rqYkx/E7QUU5jw558D/Isp9uzxAiT8ECVWLPnis7Z3fHnWGUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=lUQFBTpi; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="lUQFBTpi" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-71806621d42so565024a34.3 for ; Thu, 31 Oct 2024 09:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1730392068; x=1730996868; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8zkuoswXbu0x76VZ9dkSgVo5XUz825DeoWuELNa3+zU=; b=lUQFBTpiDsSDPy8bdekkggbtbVbRLwrZQD+pQgfLHga+zG6yWwD5qJeb2Q8aEhQBIi W2EHkk8eTISgY+o9yV7KTqo9UtPhcIxNPFwHdREpQEnYEgrK7DFhHmNbAOvwc3b4iAYt MjVQN2kfrMJmIfHj2UfAlO++PFSkKCltgD4pUtvBzBjY3hBylZcCjr9d3DL2MSLyx99u NstwVn0OCgUMpu9PLLD56jxu3PwMHNyZXIkPwIB996GBITNi6fFVtj8qv5dBACy6IZ7l 82RnsY61tdg9k/1sAxew3tbjSVk7gBF5rA4re+TgANDGD22yc9QSW/GI4KkvwELDgIxR In8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730392068; x=1730996868; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8zkuoswXbu0x76VZ9dkSgVo5XUz825DeoWuELNa3+zU=; b=AO7yZ4krETOBjtveAPMNY6xRf4eeXvepq4KpIe4MHxlkm8EcqYzkGXlEEgVFLlN3Jy ZqGOmDgznupZzLzUWzxpBdTMQzqixtO7qhHFPBd7KLAB2g6yly416VheTGw6baG8XOoI 7g9BTlbWVseFGI8XFMnano1eHtFj7IKjFryI5cDSTIIUNWzyXPqL8Ds0O9No9qckH3pF rVeCtE4PG6qWB1SfGXM1iRtJiXzflODEaZM851xcBx5RbxILXu2GHqfm9cxjn/VfD7t2 1B4bt+9VLSVzXWWg6eYHFNmz4UmBzb9Ar6rPXX5JzLH8PRVlGzOeNrItQUtPbaXWtTc0 Ud9w== X-Forwarded-Encrypted: i=1; AJvYcCWLJHHLmQ9qEOSYUultJsMM14YBAM3vsZD9AQHUqQ18zlX8/o+J8TggO/GNI7Xk9rRdYBBuzGXb4QTOQF0MHcc=@lists.linux.dev X-Gm-Message-State: AOJu0YxOMdEuoWuq9dUolfS6V83qEtewG0CVqFfvQrx8D05ivYlgsye8 kJaRZl1wvEE80IsTsLGv0/kI5VN+lKkgJDHcw51TGU39mzp/0AULMOBruVveta4= X-Google-Smtp-Source: AGHT+IGn3VcXN2vRbd8Rr0640Qt+w79Jerb9SkZNzmKhPFUbewiTnVqw/wQKsRc9oFeGGtT+FubdUQ== X-Received: by 2002:a05:6830:4123:b0:718:43b6:b0a0 with SMTP id 46e09a7af769-7189b4b76edmr3540707a34.4.1730392067759; Thu, 31 Oct 2024 09:27:47 -0700 (PDT) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7189cc69b1dsm402044a34.18.2024.10.31.09.27.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2024 09:27:47 -0700 (PDT) Message-ID: Date: Thu, 31 Oct 2024 11:27:45 -0500 Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/15] iio: light: adux1020: write_event_config: use local variable for interrupt value To: Julien Stephan , Mudit Sharma , Jonathan Cameron , Lars-Peter Clausen , Anshul Dalal , Javier Carrasco , Jean-Baptiste Maneyrol , Michael Hennerich , Cosmin Tanislav , Ramona Gradinariu , Antoniu Miclaus , Dan Robertson , Marcelo Schmitt , Matteo Martelli , Anand Ashok Dumbre , Michal Simek , Mariel Tinaco , Jagath Jog J , Lorenzo Bianconi , Subhajit Ghosh , Kevin Tsai , Linus Walleij , Benson Leung , Guenter Roeck Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev References: <20241031-iio-fix-write-event-config-signature-v2-0-2bcacbb517a2@baylibre.com> <20241031-iio-fix-write-event-config-signature-v2-6-2bcacbb517a2@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: <20241031-iio-fix-write-event-config-signature-v2-6-2bcacbb517a2@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/31/24 10:27 AM, Julien Stephan wrote: > state parameter is currently an int, but it is actually a boolean. > iio_ev_state_store is actually using kstrtobool to check user input, > then gives the converted boolean value to write_event_config. The code > in adux1020_write_event_config re-uses state parameter to store an > integer value. To prepare for updating the write_event_config signature > to use a boolean for state, introduce a new local int variable. > > Signed-off-by: Julien Stephan > --- > drivers/iio/light/adux1020.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/light/adux1020.c b/drivers/iio/light/adux1020.c > index 2e0170be077aef9aa194fab51afbb33aec02e513..db57d84da616b91add8c5d1aba08a73ce18c367e 100644 > --- a/drivers/iio/light/adux1020.c > +++ b/drivers/iio/light/adux1020.c > @@ -505,7 +505,7 @@ static int adux1020_write_event_config(struct iio_dev *indio_dev, > enum iio_event_direction dir, int state) > { > struct adux1020_data *data = iio_priv(indio_dev); > - int ret, mask; > + int ret, mask, val; > > mutex_lock(&data->lock); > > @@ -526,12 +526,12 @@ static int adux1020_write_event_config(struct iio_dev *indio_dev, > mask = ADUX1020_PROX_OFF1_INT; > > if (state) > - state = 0; > + val = 0; > else > - state = mask; > + val = mask; > > ret = regmap_update_bits(data->regmap, ADUX1020_REG_INT_MASK, > - mask, state); > + mask, val); > if (ret < 0) > goto fail; > > Instead of introducing `val`, I would rewrite this as: if (state) ret = regmap_clear_bits(...); else ret = regmap_set_bits(...);