Re: [isar-cip-core][PATCH] IMAGE_TYPEDEP:swu: Don't depend on wic

["MOESSBAUER, Felix" <felix.moessbauer@siemens.com>]

>On 16.05.23 10:50, Uladzimir Bely wrote:
>> Settings IMAGE_FSTYPE to something like "ext4 swu" or "wic.xz swu"
>> causes uncompressed '.wic' image left non-removed after the build 
>> finished. This is caused by indirect dependency on "wic" in swupdate 
>> bbclass that can't be overriden by the user in local.conf.
>> 
>> This patch removes this depencency. If the user want to use some wic 
>> partitions to be packed into .swu bundle, they could simply add 
>> directly add "wic" or "wic.xz" to IMAGE_FSTYPE.
>> 
>> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
>> ---
>>  classes/swupdate.bbclass | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/classes/swupdate.bbclass b/classes/swupdate.bbclass index 
>> 9a4d509..6f034c1 100644
>> --- a/classes/swupdate.bbclass
>> +++ b/classes/swupdate.bbclass
>> @@ -31,7 +31,7 @@ SWU_SIGNATURE_TYPE ?= "rsa"
>>  
>>  SWU_BUILDCHROOT_IMAGE_FILE ?= "${PP_DEPLOY}/${@os.path.basename(d.getVar('SWU_IMAGE_FILE'))}"
>>  
>> -IMAGE_TYPEDEP:swu = "wic ${SWU_ROOTFS_TYPE}${@get_swu_compression_type(d)}"
>> +IMAGE_TYPEDEP:swu = "${SWU_ROOTFS_TYPE}${@get_swu_compression_type(d)}"
>>  IMAGER_INSTALL:swu += "cpio ${@'openssl' if bb.utils.to_boolean(d.getVar('SWU_SIGNED')) else ''}"
>>  
>>  IMAGE_SRC_URI:swu = "file://${SWU_DESCRIPTION_FILE}.tmpl"
>
>Oops, this almost fell through the cracks.
>
> I'm indeed not seeing anything in this class referencing wic, so this removal seems logical to me. I'm just concerned if we have downstream users relying on >it and then seeing a hard to understand error. Any thoughts?

Downstream layers need to adapt to the new interface anyways (if they don't use the plain version provided by CIP).
The .wic is not needed and should be removed.

Acked!

Felix

> Jan