Re: [cip-dev] Request for review for 4.4-st78, 4.4-cip113

[Ulrich Hecht <uli@fpond.eu>]

Hi!

Thanks for the reviews.

> On 07/13/2026 12:37 PM CEST Pavel Machek via lists.cip-project.org <pavel=nabladev.com@lists.cip-project.org> wrote:
> For now, I have not checked the batman-adv stuff. Two comments below.
[...]
> ! no dec in munmap? , c/e, will we now have framebuffer refusing resize? > 0bd353e476ab2 fbdev: udlfb: add vm_ops to dlfb_ops_mmap to prevent use-after-free
> 
> I don't see how this works. mmap_count is increased in mmap, but I
> don't see corresponding decrease in munmap. 

Yup, same issue in mainline, it seems. I'll drop it.

> a > e27540595d282 md/raid5: fix soft lockup in retry_aligned_read()
> ! check_mul_overflow -- is it generic for all types? does sizeof > return size_t?...? > 16b4cbdf426d7 lib/ts_kmp: fix integer overflow in pattern length calculation
> 
> +       unsigned int prefix_tbl_len;
> +       if (unlikely(check_mul_overflow(len, sizeof(*kmp->prefix_tbl),
> +                                       &prefix_tbl_len) ||
> 
> AFAICT sizeof returns size_t, so I'd be much if prefix_tbl_len was
> size_t, too.

Fair enough, but that's how it is in mainline, and unless there is something actually broken I'd prefer to keep it that way to avoid conflicts with future patches.

CU
Uli