public inbox for cip-dev@lists.cip-project.org
 help / color / mirror / Atom feed
From: sari.sercan@siemens.com
To: cip-dev@lists.cip-project.org
Subject: Re: [isar-cip-core][PATCH] encrypt_partition: evict stale systemd SRK handle before enrollment
Date: Fri, 17 Apr 2026 00:49:37 -0700	[thread overview]
Message-ID: <1451444.1776412177481084098@lists.cip-project.org> (raw)
In-Reply-To: <9171aea6-f54d-401f-8fcd-92a902b3ec16@siemens.com>

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

On Thu, Apr 16, 2026 at 05:30 PM, Jan Kiszka wrote:

> 
> On 06.04.26 15:39, Sari, Sercan wrote:
> 
>> systemd-cryptenroll persists its TPM2 SRK at handle 0x81000001
> 
> Is that handle number officially documented? Or was it retrieved from
> the code?

Yes, officially documented in man page.

> 
> 
>> evict any stale handle before enrollment to avoid
>> "Failed to seal to TPM2: State not recoverable".
>> 
>> Signed-off-by: Sercan Sari <sari.sercan@...>
>> ---
>> .../files/encrypt_partition.systemd.script | 5 +++++
>> 1 file changed, 5 insertions(+)
>> 
>> diff --git
>> a/recipes-initramfs/initramfs-crypt-hook/files/encrypt_partition.systemd.script
>> b/recipes-initramfs/initramfs-crypt-hook/files/encrypt_partition.systemd.script
>> 
>> index 1b7c83b..841219c 100644
>> ---
>> a/recipes-initramfs/initramfs-crypt-hook/files/encrypt_partition.systemd.script
>> 
>> +++
>> b/recipes-initramfs/initramfs-crypt-hook/files/encrypt_partition.systemd.script
>> 
>> @@ -26,6 +26,11 @@ enroll_tpm2_token() {
>> #tpm_key_algorithm="$4"
>> #pcr_bank_hash_type="$5"
>> 
>> + # systemd-cryptenroll persists its TPM2 SRK at handle 0x81000001
>> + # evict any stale handle before enrollment to avoid
>> + # "Failed to seal to TPM2: State not recoverable".
>> + tpm2_evictcontrol -C o -c 0x81000001 2>/dev/null || true
> 
> "|| true" is always a bit fragile and bad for debugging. Can't we test
> for the handle first and actually fail if eviction is then not successful?

Agreed, better to look at with tpm2_getcap first, then evict.

[-- Attachment #2: Type: text/html, Size: 1676 bytes --]

      parent reply	other threads:[~2026-04-17  7:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-06 13:39 [isar-cip-core][PATCH] encrypt_partition: evict stale systemd SRK handle before enrollment Sari, Sercan
2026-04-16 14:30 ` Jan Kiszka
2026-04-16 14:56   ` Quirin Gylstorff
2026-04-16 16:03     ` Jan Kiszka
2026-04-17  8:49       ` sari.sercan
2026-04-17  7:49   ` sari.sercan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1451444.1776412177481084098@lists.cip-project.org \
    --to=sari.sercan@siemens.com \
    --cc=cip-dev@lists.cip-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox