Re: Request for review for 4.19-st18, 4.19-cip134

[Ulrich Hecht <uli@fpond.eu>]

Thanks for the reviews!

> On 06/22/2026 4:03 PM CEST Pavel Machek <pavel@nabladev.com> wrote:
> ? why the null check > ac6678cb12932 batman-adv: clear current gateway during teardown
> 
> Why the added NULL check? Mainline patch does not have it, and it will
> not break anything, but I don't understand reasoning.

In mainline batadv_gw_node_put() does this check, but in 4.19 the caller is still expected to do it.
(Found by LLM.)

> a > 8a8f72ed32162 netfilter: ipset: stop hash:* range iteration at end
> a > 239972f582859 net/sched: netem: fix queue limit check to include reordered packets
> a just a interface fix> 290ca3d4cc0fe cdrom, scsi: sr: propagate read-only status to block layer via set_disk_ro()
> a > d09410f835071 btrfs: fix double-decrement of bytes_may_use in submit_one_async_extent()
> a > 8134eaf6adc42 tipc: fix double-free in tipc_buf_append()
> a > 02d2ac7f84d00 slip: reject VJ receive packets on instances with no rstate array
> a > 50beb65e59221 netfilter: nfnetlink_osf: fix potential NULL dereference in ttl check
> a > 602bc47c8749f crypto: ccp - copy IV using skcipher ivsize
> a > b9d8a2d537ce9 wifi: brcmfmac: Fix error pointer dereference
> a > 041440c0902f7 bpf: fix end-of-list detection in cgroup_storage_get_next_key()
> a > f43b5f55f017c crypto: authencesn - reject short ahash digests during instance creation
> a just a hw bug workaround > fa4149888d92f mmc: block: use single block write in retry
> a mostly a robustness > 0ecdcd07a75d2 crypto: ccp: Don't attempt to copy PDH cert to userspace if PSP command failed
> 
> Hmm. This is wrong. In case of argp->error, we'll return 0, even when
> we have failure. AFAICT same problem exists in mainline.
> 
> a mostly a robustness > c14d8dc588ad5 crypto: ccp: Don't attempt to copy CSR to userspace if PSP command failed
> 
> Same problem here, we'll return 0 on argp->error.

Looks like it. Since this is not a backport problem, and the code with the change is AFAICT less bad than the code without the change, I'm inclined to leave the patches as they are and assume that fixes will come from upstream if this turns out to be a real issue.

CU
Uli