[cip-dev] [PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes

[ben.hutchings@codethink.co.uk (Ben Hutchings)]

On Thu, 2018-03-15 at 16:07 +0000, Fabrizio Castro wrote:
> Hi Ben,
> 
> > Subject: Re: [cip-dev][PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes
> > 
> > [This sender failed our fraud detection checks and may not be who they appear to be. Learn about spoofing at
> > http://aka.ms/LearnAboutSpoofing]
> > 
> > On Tue, 2018-03-06 at 11:34 +0000, Fabrizio Castro wrote:
> > > From: Biju Das <biju.das@bp.renesas.com>
> > > 
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > > (cherry picked from commit 310861003a0d59cb410538bcdf73a218157a111d)
> > > (modified clocks and power-domains properties, removed resets property)
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > ---
> > > ?arch/arm/boot/dts/r8a7743.dtsi | 24 ++++++++++++++++++++++++
> > > ?1 file changed, 24 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> > > index 1237746..db00959 100644
> > > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > > @@ -309,6 +309,30 @@
> > > ??????????????????????dma-channels = <15>;
> > > ??????????????};
> > > 
> > > +?????????????usb_dmac0: dma-controller at e65a0000 {
> > > +?????????????????????compatible = "renesas,usb-dmac";
> > 
> > [...]
> > 
> > Why no "renesas,r8a7743-usb-dmac" compatible string?
> 
> It's down to the dt-bindings, commit 0b2eed49875ec3605b7a71bdf05adc8c1cbd49fc
> introduces SoC specific support, this would trigger changes to the corresponding SoC
> specific DT touched by such a change,

It adds documentation of the string.  It wouldn't trigger anything.

> and as usual, where do we draw the line with
> the backporting? Would you rather I used "renesas,r8a7743-usb-dmac" instead?

In general we should make the minimum necessary changes to a backported
commit.  Deleting one of the compatible strings does not appear to be
necessary.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.