From mboxrd@z Thu Jan 1 00:00:00 1970 From: ben.hutchings@codethink.co.uk (Ben Hutchings) Date: Tue, 10 Apr 2018 17:51:33 +0100 Subject: [cip-dev] [PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes In-Reply-To: References: <1520336087-12870-1-git-send-email-fabrizio.castro@bp.renesas.com> <1520336087-12870-7-git-send-email-fabrizio.castro@bp.renesas.com> <1521067650.23626.110.camel@codethink.co.uk> Message-ID: <1523379093.2654.186.camel@codethink.co.uk> To: cip-dev@lists.cip-project.org List-Id: cip-dev.lists.cip-project.org On Thu, 2018-03-15 at 16:07 +0000, Fabrizio Castro wrote: > Hi Ben, > > > Subject: Re: [cip-dev][PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes > > > > [This sender failed our fraud detection checks and may not be who they appear to be. Learn about spoofing at > > http://aka.ms/LearnAboutSpoofing] > > > > On Tue, 2018-03-06 at 11:34 +0000, Fabrizio Castro wrote: > > > From: Biju Das > > > > > > Signed-off-by: Biju Das > > > Signed-off-by: Chris Paterson > > > Reviewed-by: Geert Uytterhoeven > > > Signed-off-by: Simon Horman > > > (cherry picked from commit 310861003a0d59cb410538bcdf73a218157a111d) > > > (modified clocks and power-domains properties, removed resets property) > > > Signed-off-by: Fabrizio Castro > > > --- > > > ?arch/arm/boot/dts/r8a7743.dtsi | 24 ++++++++++++++++++++++++ > > > ?1 file changed, 24 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > > > index 1237746..db00959 100644 > > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > > > @@ -309,6 +309,30 @@ > > > ??????????????????????dma-channels = <15>; > > > ??????????????}; > > > > > > +?????????????usb_dmac0: dma-controller at e65a0000 { > > > +?????????????????????compatible = "renesas,usb-dmac"; > > > > [...] > > > > Why no "renesas,r8a7743-usb-dmac" compatible string? > > It's down to the dt-bindings, commit 0b2eed49875ec3605b7a71bdf05adc8c1cbd49fc > introduces SoC specific support, this would trigger changes to the corresponding SoC > specific DT touched by such a change, It adds documentation of the string. It wouldn't trigger anything. > and as usual, where do we draw the line with > the backporting? Would you rather I used "renesas,r8a7743-usb-dmac" instead? In general we should make the minimum necessary changes to a backported commit. Deleting one of the compatible strings does not appear to be necessary. Ben. -- Ben Hutchings Software Developer, Codethink Ltd.