* [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743
@ 2018-03-06 11:34 Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 1/7] usb: renesas_usbhs: add SoC names to compatibility string documentation Fabrizio Castro
` (7 more replies)
0 siblings, 8 replies; 13+ messages in thread
From: Fabrizio Castro @ 2018-03-06 11:34 UTC (permalink / raw)
To: cip-dev
Dear All,
this series backports all the patches necessary to add HSUSB support
to the r8a7743.
Thanks,
Fabrizio
Biju Das (5):
usb: renesas_usbhs: Add compatible string for r8a7743/5
ARM: dts: r8a7743: Add HS-USB device node
ARM: dts: iwg20d-q7: Enable HS-USB
ARM: dts: r8a7743: Add USB-DMAC device nodes
ARM: dts: r8a7743: Enable DMA for HSUSB
Simon Horman (2):
usb: renesas_usbhs: add SoC names to compatibility string
documentation
usb: renesas_usbhs: add fallback compatibility strings
.../devicetree/bindings/usb/renesas_usbhs.txt | 22 ++++++++----
arch/arm/boot/dts/iwg20d-q7-common.dtsi | 7 +++-
arch/arm/boot/dts/r8a7743.dtsi | 40 ++++++++++++++++++++++
drivers/usb/renesas_usbhs/common.c | 9 +++++
4 files changed, 71 insertions(+), 7 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 13+ messages in thread
* [cip-dev] [PATCH 1/7] usb: renesas_usbhs: add SoC names to compatibility string documentation
2018-03-06 11:34 [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743 Fabrizio Castro
@ 2018-03-06 11:34 ` Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 2/7] usb: renesas_usbhs: add fallback compatibility strings Fabrizio Castro
` (6 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Fabrizio Castro @ 2018-03-06 11:34 UTC (permalink / raw)
To: cip-dev
From: Simon Horman <horms+renesas@verge.net.au>
This extends the documentation of compatibility strings a little to
include the SoC names.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
(cherry picked from commit 89d75bf18d0e3e9a02961f537c87d7991df3bd32)
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index 7d48f63..a14c0bb 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -2,10 +2,10 @@ Renesas Electronics USBHS driver
Required properties:
- compatible: Must contain one of the following:
- - "renesas,usbhs-r8a7790"
- - "renesas,usbhs-r8a7791"
- - "renesas,usbhs-r8a7794"
- - "renesas,usbhs-r8a7795"
+ - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
+ - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
+ - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
+ - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
- reg: Base address and length of the register for the USBHS
- interrupts: Interrupt specifier for the USBHS
- clocks: A list of phandle + clock specifier pairs
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [cip-dev] [PATCH 2/7] usb: renesas_usbhs: add fallback compatibility strings
2018-03-06 11:34 [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743 Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 1/7] usb: renesas_usbhs: add SoC names to compatibility string documentation Fabrizio Castro
@ 2018-03-06 11:34 ` Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 3/7] usb: renesas_usbhs: Add compatible string for r8a7743/5 Fabrizio Castro
` (5 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Fabrizio Castro @ 2018-03-06 11:34 UTC (permalink / raw)
To: cip-dev
From: Simon Horman <horms+renesas@verge.net.au>
Add fallback compatibility strings for R-Car Gen2 and Gen3.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
(cherry picked from commit 2f1a993a0da652c50e08159f16590b7f9820d192)
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 12 ++++++++++--
drivers/usb/renesas_usbhs/common.c | 9 +++++++++
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index a14c0bb..45d9ae1 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -1,11 +1,19 @@
Renesas Electronics USBHS driver
Required properties:
- - compatible: Must contain one of the following:
+ - compatible: Must contain one or more of the following:
+
- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
+ - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
+ - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
+
+ When compatible with the generic version, nodes must list the
+ SoC-specific version corresponding to the platform first followed
+ by the generic version.
+
- reg: Base address and length of the register for the USBHS
- interrupts: Interrupt specifier for the USBHS
- clocks: A list of phandle + clock specifier pairs
@@ -22,7 +30,7 @@ Optional properties:
Example:
usbhs: usb at e6590000 {
- compatible = "renesas,usbhs-r8a7790";
+ compatible = "renesas,usbhs-r8a7790", "renesas,rcar-gen2-usbhs";
reg = <0 0xe6590000 0 0x100>;
interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 005da08..2fa4479 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -481,6 +481,15 @@ static const struct of_device_id usbhs_of_match[] = {
.compatible = "renesas,usbhs-r8a7795",
.data = (void *)USBHS_TYPE_RCAR_GEN2,
},
+ {
+ .compatible = "renesas,rcar-gen2-usbhs",
+ .data = (void *)USBHS_TYPE_RCAR_GEN2,
+ },
+ {
+ /* Gen3 is compatible with Gen2 */
+ .compatible = "renesas,rcar-gen3-usbhs",
+ .data = (void *)USBHS_TYPE_RCAR_GEN2,
+ },
{ },
};
MODULE_DEVICE_TABLE(of, usbhs_of_match);
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [cip-dev] [PATCH 3/7] usb: renesas_usbhs: Add compatible string for r8a7743/5
2018-03-06 11:34 [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743 Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 1/7] usb: renesas_usbhs: add SoC names to compatibility string documentation Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 2/7] usb: renesas_usbhs: add fallback compatibility strings Fabrizio Castro
@ 2018-03-06 11:34 ` Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 4/7] ARM: dts: r8a7743: Add HS-USB device node Fabrizio Castro
` (4 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Fabrizio Castro @ 2018-03-06 11:34 UTC (permalink / raw)
To: cip-dev
From: Biju Das <biju.das@bp.renesas.com>
This patch adds support for r8a7743/5 SoCs. The Renesas RZ/G1[ME]
(R8A7743/5) usbhs is identical to the R-Car Gen2 family.
No driver change is needed due to the fallback compatible value
"renesas,rcar-gen2-usbhs".
Adding the SoC-specific compatible values here has two purposes:
1. Document which SoCs have this hardware module,
2. Allow checkpatch to validate compatible values.
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
(cherry picked from commit e0d63c4083852e07655dfcda1320504c304218be)
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index 45d9ae1..65af38c 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -3,6 +3,8 @@ Renesas Electronics USBHS driver
Required properties:
- compatible: Must contain one or more of the following:
+ - "renesas,usbhs-r8a7743" for r8a7743 (RZ/G1M) compatible device
+ - "renesas,usbhs-r8a7745" for r8a7745 (RZ/G1E) compatible device
- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [cip-dev] [PATCH 4/7] ARM: dts: r8a7743: Add HS-USB device node
2018-03-06 11:34 [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743 Fabrizio Castro
` (2 preceding siblings ...)
2018-03-06 11:34 ` [cip-dev] [PATCH 3/7] usb: renesas_usbhs: Add compatible string for r8a7743/5 Fabrizio Castro
@ 2018-03-06 11:34 ` Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 5/7] ARM: dts: iwg20d-q7: Enable HS-USB Fabrizio Castro
` (3 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Fabrizio Castro @ 2018-03-06 11:34 UTC (permalink / raw)
To: cip-dev
From: Biju Das <biju.das@bp.renesas.com>
Define the R8A7743 generic part of the HS-USB device node. It is up to the
board file to enable the device.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
(cherry picked from commit 4b4a3b1c33b7a389d90624683d8f1a8d1dc2affa)
(modified clocks, power-domains properties and removed resets property)
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
arch/arm/boot/dts/r8a7743.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 1b17a20..1237746 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -1185,6 +1185,19 @@
};
};
+ hsusb: usb at e6590000 {
+ compatible = "renesas,usbhs-r8a7743",
+ "renesas,rcar-gen2-usbhs";
+ reg = <0 0xe6590000 0 0x100>;
+ interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp7_clks R8A7743_CLK_HSUSB>;
+ power-domains = <&cpg_clocks>;
+ renesas,buswait = <4>;
+ phys = <&usb0 1>;
+ phy-names = "usb";
+ status = "disabled";
+ };
+
usbphy: usb-phy at e6590100 {
compatible = "renesas,usb-phy-r8a7743",
"renesas,rcar-gen2-usb-phy";
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [cip-dev] [PATCH 5/7] ARM: dts: iwg20d-q7: Enable HS-USB
2018-03-06 11:34 [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743 Fabrizio Castro
` (3 preceding siblings ...)
2018-03-06 11:34 ` [cip-dev] [PATCH 4/7] ARM: dts: r8a7743: Add HS-USB device node Fabrizio Castro
@ 2018-03-06 11:34 ` Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes Fabrizio Castro
` (2 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Fabrizio Castro @ 2018-03-06 11:34 UTC (permalink / raw)
To: cip-dev
From: Biju Das <biju.das@bp.renesas.com>
Enable HS-USB device for the iWave G20D-Q7 carrier board based on
RZ/G1M.
Also disable the host mode support on usb otg port by default to avoid
pin conflicts.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
(cherry picked from commit 405b580227ff1ae8fde82a666a2a5c0391a7e64a)
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
arch/arm/boot/dts/iwg20d-q7-common.dtsi | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
index fbb5215..8f203c5 100644
--- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi
+++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
@@ -59,6 +59,12 @@
};
};
+&hsusb {
+ status = "okay";
+ pinctrl-0 = <&usb0_pins>;
+ pinctrl-names = "default";
+};
+
&i2c2 {
pinctrl-0 = <&i2c2_pins>;
pinctrl-names = "default";
@@ -111,7 +117,6 @@
};
&pci0 {
- status = "okay";
pinctrl-0 = <&usb0_pins>;
pinctrl-names = "default";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [cip-dev] [PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes
2018-03-06 11:34 [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743 Fabrizio Castro
` (4 preceding siblings ...)
2018-03-06 11:34 ` [cip-dev] [PATCH 5/7] ARM: dts: iwg20d-q7: Enable HS-USB Fabrizio Castro
@ 2018-03-06 11:34 ` Fabrizio Castro
2018-03-14 22:47 ` Ben Hutchings
2018-03-06 11:34 ` [cip-dev] [PATCH 7/7] ARM: dts: r8a7743: Enable DMA for HSUSB Fabrizio Castro
2018-04-10 17:16 ` [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743 Ben Hutchings
7 siblings, 1 reply; 13+ messages in thread
From: Fabrizio Castro @ 2018-03-06 11:34 UTC (permalink / raw)
To: cip-dev
From: Biju Das <biju.das@bp.renesas.com>
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
(cherry picked from commit 310861003a0d59cb410538bcdf73a218157a111d)
(modified clocks and power-domains properties, removed resets property)
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
arch/arm/boot/dts/r8a7743.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 1237746..db00959 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -309,6 +309,30 @@
dma-channels = <15>;
};
+ usb_dmac0: dma-controller at e65a0000 {
+ compatible = "renesas,usb-dmac";
+ reg = <0 0xe65a0000 0 0x100>;
+ interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "ch0", "ch1";
+ clocks = <&mstp3_clks R8A7743_CLK_USBDMAC0>;
+ power-domains = <&cpg_clocks>;
+ #dma-cells = <1>;
+ dma-channels = <2>;
+ };
+
+ usb_dmac1: dma-controller at e65b0000 {
+ compatible = "renesas,usb-dmac";
+ reg = <0 0xe65b0000 0 0x100>;
+ interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "ch0", "ch1";
+ clocks = <&mstp3_clks R8A7743_CLK_USBDMAC1>;
+ power-domains = <&cpg_clocks>;
+ #dma-cells = <1>;
+ dma-channels = <2>;
+ };
+
/* The memory map in the User's Manual maps the cores to bus
* numbers
*/
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [cip-dev] [PATCH 7/7] ARM: dts: r8a7743: Enable DMA for HSUSB
2018-03-06 11:34 [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743 Fabrizio Castro
` (5 preceding siblings ...)
2018-03-06 11:34 ` [cip-dev] [PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes Fabrizio Castro
@ 2018-03-06 11:34 ` Fabrizio Castro
2018-04-10 17:16 ` [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743 Ben Hutchings
7 siblings, 0 replies; 13+ messages in thread
From: Fabrizio Castro @ 2018-03-06 11:34 UTC (permalink / raw)
To: cip-dev
From: Biju Das <biju.das@bp.renesas.com>
This patch adds DMA properties to the HSUSB node.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
(cherry picked from commit e0a10e7b070624965f20205c59fb2a0c0b465782)
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
arch/arm/boot/dts/r8a7743.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index db00959..40137cf 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -1215,6 +1215,9 @@
reg = <0 0xe6590000 0 0x100>;
interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&mstp7_clks R8A7743_CLK_HSUSB>;
+ dmas = <&usb_dmac0 0>, <&usb_dmac0 1>,
+ <&usb_dmac1 0>, <&usb_dmac1 1>;
+ dma-names = "ch0", "ch1", "ch2", "ch3";
power-domains = <&cpg_clocks>;
renesas,buswait = <4>;
phys = <&usb0 1>;
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [cip-dev] [PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes
2018-03-06 11:34 ` [cip-dev] [PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes Fabrizio Castro
@ 2018-03-14 22:47 ` Ben Hutchings
2018-03-15 16:07 ` Fabrizio Castro
0 siblings, 1 reply; 13+ messages in thread
From: Ben Hutchings @ 2018-03-14 22:47 UTC (permalink / raw)
To: cip-dev
On Tue, 2018-03-06 at 11:34 +0000, Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> (cherry picked from commit 310861003a0d59cb410538bcdf73a218157a111d)
> (modified clocks and power-domains properties, removed resets property)
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> ?arch/arm/boot/dts/r8a7743.dtsi | 24 ++++++++++++++++++++++++
> ?1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> index 1237746..db00959 100644
> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -309,6 +309,30 @@
> ? dma-channels = <15>;
> ? };
> ?
> + usb_dmac0: dma-controller at e65a0000 {
> + compatible = "renesas,usb-dmac";
[...]
Why no "renesas,r8a7743-usb-dmac" compatible string?
Ben.
--
Ben Hutchings
Software Developer, Codethink Ltd.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [cip-dev] [PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes
2018-03-14 22:47 ` Ben Hutchings
@ 2018-03-15 16:07 ` Fabrizio Castro
2018-04-10 16:51 ` Ben Hutchings
0 siblings, 1 reply; 13+ messages in thread
From: Fabrizio Castro @ 2018-03-15 16:07 UTC (permalink / raw)
To: cip-dev
Hi Ben,
> Subject: Re: [cip-dev][PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes
>
> [This sender failed our fraud detection checks and may not be who they appear to be. Learn about spoofing at
> http://aka.ms/LearnAboutSpoofing]
>
> On Tue, 2018-03-06 at 11:34 +0000, Fabrizio Castro wrote:
> > From: Biju Das <biju.das@bp.renesas.com>
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > (cherry picked from commit 310861003a0d59cb410538bcdf73a218157a111d)
> > (modified clocks and power-domains properties, removed resets property)
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> > arch/arm/boot/dts/r8a7743.dtsi | 24 ++++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> > index 1237746..db00959 100644
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -309,6 +309,30 @@
> > dma-channels = <15>;
> > };
> >
> > + usb_dmac0: dma-controller at e65a0000 {
> > + compatible = "renesas,usb-dmac";
> [...]
>
> Why no "renesas,r8a7743-usb-dmac" compatible string?
It's down to the dt-bindings, commit 0b2eed49875ec3605b7a71bdf05adc8c1cbd49fc
introduces SoC specific support, this would trigger changes to the corresponding SoC
specific DT touched by such a change, and as usual, where do we draw the line with
the backporting? Would you rather I used "renesas,r8a7743-usb-dmac" instead?
Thanks,
Fab
>
> Ben.
>
> --
> Ben Hutchings
> Software Developer, Codethink Ltd.
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [cip-dev] [PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes
2018-03-15 16:07 ` Fabrizio Castro
@ 2018-04-10 16:51 ` Ben Hutchings
0 siblings, 0 replies; 13+ messages in thread
From: Ben Hutchings @ 2018-04-10 16:51 UTC (permalink / raw)
To: cip-dev
On Thu, 2018-03-15 at 16:07 +0000, Fabrizio Castro wrote:
> Hi Ben,
>
> > Subject: Re: [cip-dev][PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes
> >
> > [This sender failed our fraud detection checks and may not be who they appear to be. Learn about spoofing at
> > http://aka.ms/LearnAboutSpoofing]
> >
> > On Tue, 2018-03-06 at 11:34 +0000, Fabrizio Castro wrote:
> > > From: Biju Das <biju.das@bp.renesas.com>
> > >
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > > (cherry picked from commit 310861003a0d59cb410538bcdf73a218157a111d)
> > > (modified clocks and power-domains properties, removed resets property)
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > ---
> > > ?arch/arm/boot/dts/r8a7743.dtsi | 24 ++++++++++++++++++++++++
> > > ?1 file changed, 24 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> > > index 1237746..db00959 100644
> > > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > > @@ -309,6 +309,30 @@
> > > ??????????????????????dma-channels = <15>;
> > > ??????????????};
> > >
> > > +?????????????usb_dmac0: dma-controller at e65a0000 {
> > > +?????????????????????compatible = "renesas,usb-dmac";
> >
> > [...]
> >
> > Why no "renesas,r8a7743-usb-dmac" compatible string?
>
> It's down to the dt-bindings, commit 0b2eed49875ec3605b7a71bdf05adc8c1cbd49fc
> introduces SoC specific support, this would trigger changes to the corresponding SoC
> specific DT touched by such a change,
It adds documentation of the string. It wouldn't trigger anything.
> and as usual, where do we draw the line with
> the backporting? Would you rather I used "renesas,r8a7743-usb-dmac" instead?
In general we should make the minimum necessary changes to a backported
commit. Deleting one of the compatible strings does not appear to be
necessary.
Ben.
--
Ben Hutchings
Software Developer, Codethink Ltd.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743
2018-03-06 11:34 [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743 Fabrizio Castro
` (6 preceding siblings ...)
2018-03-06 11:34 ` [cip-dev] [PATCH 7/7] ARM: dts: r8a7743: Enable DMA for HSUSB Fabrizio Castro
@ 2018-04-10 17:16 ` Ben Hutchings
2018-04-10 17:45 ` Fabrizio Castro
7 siblings, 1 reply; 13+ messages in thread
From: Ben Hutchings @ 2018-04-10 17:16 UTC (permalink / raw)
To: cip-dev
I've applied this series, thanks. I added back the compatible strings
that you left out of the last patch, since I didn't see any need to
diverge from upstream there.
Ben.
On Tue, 2018-03-06 at 11:34 +0000, Fabrizio Castro wrote:
> Dear All,
>
> this series backports all the patches necessary to add HSUSB support
> to the r8a7743.
>
> Thanks,
> Fabrizio
>
> Biju Das (5):
> ? usb: renesas_usbhs: Add compatible string for r8a7743/5
> ? ARM: dts: r8a7743: Add HS-USB device node
> ? ARM: dts: iwg20d-q7: Enable HS-USB
> ? ARM: dts: r8a7743: Add USB-DMAC device nodes
> ? ARM: dts: r8a7743: Enable DMA for HSUSB
>
> Simon Horman (2):
> ? usb: renesas_usbhs: add SoC names to compatibility string
> ????documentation
> ? usb: renesas_usbhs: add fallback compatibility strings
>
> ?.../devicetree/bindings/usb/renesas_usbhs.txt??????| 22 ++++++++----
> ?arch/arm/boot/dts/iwg20d-q7-common.dtsi????????????|??7 +++-
> ?arch/arm/boot/dts/r8a7743.dtsi?????????????????????| 40 ++++++++++++++++++++++
> ?drivers/usb/renesas_usbhs/common.c?????????????????|??9 +++++
> ?4 files changed, 71 insertions(+), 7 deletions(-)
>
--
Ben Hutchings
Software Developer, Codethink Ltd.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743
2018-04-10 17:16 ` [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743 Ben Hutchings
@ 2018-04-10 17:45 ` Fabrizio Castro
0 siblings, 0 replies; 13+ messages in thread
From: Fabrizio Castro @ 2018-04-10 17:45 UTC (permalink / raw)
To: cip-dev
Hello Ben,
> Subject: Re: [cip-dev][PATCH 0/7] Add HSUSB to r8a7743
>
> I've applied this series, thanks. I added back the compatible strings
> that you left out of the last patch, since I didn't see any need to
> diverge from upstream there.
Ok.
Thanks,
Fab
>
> Ben.
>
> On Tue, 2018-03-06 at 11:34 +0000, Fabrizio Castro wrote:
> > Dear All,
> >
> > this series backports all the patches necessary to add HSUSB support
> > to the r8a7743.
> >
> > Thanks,
> > Fabrizio
> >
> > Biju Das (5):
> > usb: renesas_usbhs: Add compatible string for r8a7743/5
> > ARM: dts: r8a7743: Add HS-USB device node
> > ARM: dts: iwg20d-q7: Enable HS-USB
> > ARM: dts: r8a7743: Add USB-DMAC device nodes
> > ARM: dts: r8a7743: Enable DMA for HSUSB
> >
> > Simon Horman (2):
> > usb: renesas_usbhs: add SoC names to compatibility string
> > documentation
> > usb: renesas_usbhs: add fallback compatibility strings
> >
> > .../devicetree/bindings/usb/renesas_usbhs.txt | 22 ++++++++----
> > arch/arm/boot/dts/iwg20d-q7-common.dtsi | 7 +++-
> > arch/arm/boot/dts/r8a7743.dtsi | 40 ++++++++++++++++++++++
> > drivers/usb/renesas_usbhs/common.c | 9 +++++
> > 4 files changed, 71 insertions(+), 7 deletions(-)
> >
> --
> Ben Hutchings
> Software Developer, Codethink Ltd.
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-04-10 17:45 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-06 11:34 [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743 Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 1/7] usb: renesas_usbhs: add SoC names to compatibility string documentation Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 2/7] usb: renesas_usbhs: add fallback compatibility strings Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 3/7] usb: renesas_usbhs: Add compatible string for r8a7743/5 Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 4/7] ARM: dts: r8a7743: Add HS-USB device node Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 5/7] ARM: dts: iwg20d-q7: Enable HS-USB Fabrizio Castro
2018-03-06 11:34 ` [cip-dev] [PATCH 6/7] ARM: dts: r8a7743: Add USB-DMAC device nodes Fabrizio Castro
2018-03-14 22:47 ` Ben Hutchings
2018-03-15 16:07 ` Fabrizio Castro
2018-04-10 16:51 ` Ben Hutchings
2018-03-06 11:34 ` [cip-dev] [PATCH 7/7] ARM: dts: r8a7743: Enable DMA for HSUSB Fabrizio Castro
2018-04-10 17:16 ` [cip-dev] [PATCH 0/7] Add HSUSB to r8a7743 Ben Hutchings
2018-04-10 17:45 ` Fabrizio Castro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox