[cip-dev] [PATCH 57/62] thermal: rcar: enable to use thermal-zone on DT

[ben.hutchings@codethink.co.uk (Ben Hutchings)]

On Mon, 2018-05-21 at 13:46 +0000, Biju Das wrote:
> Hi Ben,
> 
> Thanks for the feedback.
> 
> > Subject: Re: [PATCH 57/62] thermal: rcar: enable to use thermal-zone on DT
> > 
> > On Thu, 2018-05-10 at 16:08 +0100, Biju Das wrote:
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > 
> > > This patch enables to use thermal-zone on DT if it was calles as
> > > "renesas,rcar-thermal-gen2".
> > > Previous style (= non thermal-zone) is still supported by
> > > "renesas,rcar-thermal" to keep compatibility for "git bisect".
> > > 
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > Signed-off-by: Eduardo Valentin <edubezval@gmail.com> (cherry picked
> > > from commit 8b477ea56383dc8b838f1f8b506e4571c14ceb30)
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > 
> > [...]
> > > --- a/drivers/thermal/rcar_thermal.c
> > > +++ b/drivers/thermal/rcar_thermal.c
> > 
> > [...]
> > > @@ -463,7 +492,13 @@ static int rcar_thermal_probe(struct
> > 
> > platform_device *pdev)
> > > ?if (ret < 0)
> > > ?goto error_unregister;
> > > 
> > > -priv->zone = thermal_zone_device_register("rcar_thermal",
> > > +if (of_data == USE_OF_THERMAL)
> > > +priv->zone = thermal_zone_of_sensor_register(
> > > +dev, i, priv,
> > > +
> > 
> > &rcar_thermal_zone_of_ops);
> > 
> > Doesn't this require a corresponding change to use
> > thermal_zone_of_sensor_unregister()?
> 
> As per??the commit(d4b23c5c434a) message "devm_thermal_zone_of_sensor_register() case doesn't need to call???thermal_zone_device_unregister()"
> 
> We are not using devm version of thermal_zone_of_sensor_register, so??I guess the below commit is not required.
> d4b23c5c434a ("thermal: rcar_thermal: don't call thermal_zone_device_unregister when USE_OF_THERMAL")

Even so, it is wrong to use thermal_zone_of_sensor_register() and then
thermal_zone_device_unregister().

> > It looks like this was fixed upstream by commits 5e325868aa59
> > ("thermal: convert rcar_thermal to use
> > devm_thermal_zone_of_sensor_register") and d4b23c5c434a ("thermal:
> > rcar_thermal: don't call thermal_zone_device_unregister when
> > USE_OF_THERMAL").
> 
> The commit 5e325868aa59 ("thermal: convert rcar_thermal to use devm_thermal_zone_of_sensor_register")
> depend upon the commit e498b4984 ("thermal: of-thermal: Add devm version of??thermal_zone_of_sensor_register")
> which is outside the scope of renesas thermal driver.
> 
> ?Are you ok for backporting the above patch? If yes, then it make sense to backport the commits 5e325868aa59 and d4b23c5c434a.

Yes, I think this is OK.  Commit?e498b4984 doesn't change any existing
functions so it should be safe to add.

Ben.

-- 
Ben Hutchings, Software Developer                ?        Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom
We respect your privacy.?? See https://www.codethink.co.uk/privacy.html