public inbox for cip-dev@lists.cip-project.org
 help / color / mirror / Atom feed
* [cip-dev] [PATCH] ARM: dts: r8a7743: Add VSP support
@ 2018-05-29 10:08 Fabrizio Castro
  2018-05-30 17:24 ` Ben Hutchings
  0 siblings, 1 reply; 3+ messages in thread
From: Fabrizio Castro @ 2018-05-29 10:08 UTC (permalink / raw)
  To: cip-dev

From: Biju Das <biju.das@bp.renesas.com>

Add VSP support to SoC DT.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
(cherry picked from commit ff9b22610e8c08946f9787d9e0d1a87489624417)
(dropped resets property. changed clocks and power-domains properties.
added vsp device configuration)
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
Hello Ben,

this patch applies on top of v4.4.130-cip23.

Thanks,
Fab

 arch/arm/boot/dts/r8a7743.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index eb3cdc8..e8082f8 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -1330,6 +1330,48 @@
 			};
 		};
 
+		vsp at fe928000 {
+			compatible = "renesas,vsp1";
+			reg = <0 0xfe928000 0 0x8000>;
+			interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&mstp1_clks R8A7743_CLK_VSP1_S>;
+			power-domains = <&cpg_clocks>;
+
+			renesas,has-lut;
+			renesas,has-sru;
+			renesas,#rpf = <5>;
+			renesas,#uds = <3>;
+			renesas,#wpf = <4>;
+		};
+
+		vsp at fe930000 {
+			compatible = "renesas,vsp1";
+			reg = <0 0xfe930000 0 0x8000>;
+			interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&mstp1_clks R8A7743_CLK_VSP1_DU0>;
+			power-domains = <&cpg_clocks>;
+
+			renesas,has-lif;
+			renesas,has-lut;
+			renesas,#rpf = <4>;
+			renesas,#uds = <1>;
+			renesas,#wpf = <4>;
+		};
+
+		vsp at fe938000 {
+			compatible = "renesas,vsp1";
+			reg = <0 0xfe938000 0 0x8000>;
+			interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&mstp1_clks R8A7743_CLK_VSP1_DU1>;
+			power-domains = <&cpg_clocks>;
+
+			renesas,has-lif;
+			renesas,has-lut;
+			renesas,#rpf = <4>;
+			renesas,#uds = <1>;
+			renesas,#wpf = <4>;
+		};
+
 		pci0: pci at ee090000 {
 			compatible = "renesas,pci-r8a7743",
 				     "renesas,pci-rcar-gen2";
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [cip-dev] [PATCH] ARM: dts: r8a7743: Add VSP support
  2018-05-29 10:08 [cip-dev] [PATCH] ARM: dts: r8a7743: Add VSP support Fabrizio Castro
@ 2018-05-30 17:24 ` Ben Hutchings
  2018-05-31  9:25   ` Fabrizio Castro
  0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2018-05-30 17:24 UTC (permalink / raw)
  To: cip-dev

On Tue, 2018-05-29 at 11:08 +0100, Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
> 
> Add VSP support to SoC DT.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> (cherry picked from commit ff9b22610e8c08946f9787d9e0d1a87489624417)

This is wrong; the upstream commit is
0565605aa9887a3d6423fb08c0cbb0de3a22f838.

> (dropped resets property. changed clocks and power-domains properties.
> added vsp device configuration)
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
> Hello Ben,
> 
> this patch applies on top of v4.4.130-cip23.
[...]

I applied this and fixed the upstream commit reference.  Thanks.

Ben.

-- 
Ben Hutchings, Software Developer                ?        Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom
We respect your privacy.?? See https://www.codethink.co.uk/privacy.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [cip-dev] [PATCH] ARM: dts: r8a7743: Add VSP support
  2018-05-30 17:24 ` Ben Hutchings
@ 2018-05-31  9:25   ` Fabrizio Castro
  0 siblings, 0 replies; 3+ messages in thread
From: Fabrizio Castro @ 2018-05-31  9:25 UTC (permalink / raw)
  To: cip-dev



> -----Original Message-----
> From: Ben Hutchings [mailto:ben.hutchings at codethink.co.uk]
> Sent: 30 May 2018 18:24
> To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Cc: cip-dev at lists.cip-project.org; Chris Paterson <Chris.Paterson2@renesas.com>; Biju Das <biju.das@bp.renesas.com>
> Subject: Re: [PATCH] ARM: dts: r8a7743: Add VSP support
>
> On Tue, 2018-05-29 at 11:08 +0100, Fabrizio Castro wrote:
> > From: Biju Das <biju.das@bp.renesas.com>
> >
> > Add VSP support to SoC DT.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > (cherry picked from commit ff9b22610e8c08946f9787d9e0d1a87489624417)
>
> This is wrong; the upstream commit is
> 0565605aa9887a3d6423fb08c0cbb0de3a22f838.

Yeah you are right

>
> > (dropped resets property. changed clocks and power-domains properties.
> > added vsp device configuration)
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > Hello Ben,
> >
> > this patch applies on top of v4.4.130-cip23.
> [...]
>
> I applied this and fixed the upstream commit reference.  Thanks.

Thank you for fixing.

Cheers,
Fab

>
> Ben.
>
> --
> Ben Hutchings, Software Developer                         Codethink Ltd
> https://www.codethink.co.uk/                 Dale House, 35 Dale Street
>                                      Manchester, M1 2HF, United Kingdom
> We respect your privacy.   See https://www.codethink.co.uk/privacy.html



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-31  9:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-29 10:08 [cip-dev] [PATCH] ARM: dts: r8a7743: Add VSP support Fabrizio Castro
2018-05-30 17:24 ` Ben Hutchings
2018-05-31  9:25   ` Fabrizio Castro

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox