From mboxrd@z Thu Jan 1 00:00:00 1970 From: ben.hutchings@codethink.co.uk (Ben Hutchings) Date: Tue, 10 Jul 2018 18:12:15 +0100 Subject: [cip-dev] [PATCH 62/86] ARM: dts: r8a7745: Add operating-points to cpu0 In-Reply-To: References: <1530283167-14050-1-git-send-email-fabrizio.castro@bp.renesas.com> <1530283167-14050-63-git-send-email-fabrizio.castro@bp.renesas.com> <1530827145.21552.2.camel@codethink.co.uk> <1531076512.21552.3.camel@codethink.co.uk> Message-ID: <1531242735.21552.14.camel@codethink.co.uk> To: cip-dev@lists.cip-project.org List-Id: cip-dev.lists.cip-project.org On Mon, 2018-07-09 at 10:29 +0000, Fabrizio Castro wrote: > Hello Ben, > > Thank you for your feedback! > > > -----Original Message----- > > From: Ben Hutchings [mailto:ben.hutchings at codethink.co.uk] > > Sent: 08 July 2018 20:02 > > To: Fabrizio Castro > > Cc: cip-dev at lists.cip-project.org; Chris Paterson ; Biju Das > > Subject: Re: [cip-dev][PATCH 62/86] ARM: dts: r8a7745: Add > > operating-points to cpu0 > > > > On Fri, 2018-07-06 at 10:00 +0000, Fabrizio Castro wrote: > > > Hello Ben, > > > > > > Thank you for your feedback. > > > > > > > Subject: Re: [cip-dev][PATCH 62/86] ARM: dts: r8a7745: Add > > > > operating-points to cpu0 > > > > > > > > On Fri, 2018-06-29 at 15:39 +0100, Fabrizio Castro wrote: > > > > > shmobile_defconfig builds cpu freq into the kernel by default, > > > > > therefore we get error and warning messages at boot, when > > > > > hotplugging cpus, and when waking up from suspend to RAM. > > > > > > > > > > Although the r8a7745 SoC does not support DVFS, defining one > > > > > operating point makes cpu freq happy and therefore all of the > > > > > nasty messages disappear. > > > > > > > > Why was this not needed upstream? > > > > > > Since there is a chance for the OPP to be registered dynamically the > > > upstream kernel won't print error messages (only debug messages), as > > > opposed to the CIP kernel which will print error messages. Have a > > > look at 5b60697cd89cf5a438b2984e11859228e5ec1c6b. > > > > [...] > > > > Then I will cherry-pick that commit instead. > > Could you please cherry-pick this commit too then: > 035ed07208dc501d023873447113f3f178592156 ("PM / OPP: Move error > message to debug level") OK, done. Ben. -- Ben Hutchings, Software Developer ? Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom