From mboxrd@z Thu Jan 1 00:00:00 1970 From: ben.hutchings@codethink.co.uk (Ben Hutchings) Date: Sat, 18 Aug 2018 03:20:00 +0100 Subject: [cip-dev] [PATCH 14/42] watchdog: renesas-wdt: add driver In-Reply-To: <1532626980-17190-15-git-send-email-fabrizio.castro@bp.renesas.com> References: <1532626980-17190-1-git-send-email-fabrizio.castro@bp.renesas.com> <1532626980-17190-15-git-send-email-fabrizio.castro@bp.renesas.com> Message-ID: <1534558800.3135.20.camel@codethink.co.uk> To: cip-dev@lists.cip-project.org List-Id: cip-dev.lists.cip-project.org On Thu, 2018-07-26 at 18:42 +0100, Fabrizio Castro wrote: > From: Wolfram Sang > > Add support for watchdogs (RWDT and SWDT) found on RCar Gen3 based SoCs > from Renesas. > > Signed-off-by: Wolfram Sang > Signed-off-by: Guenter Roeck > Signed-off-by: Wim Van Sebroeck > (cherry picked from commit bd99b68ed7f96c9c845aad2a25f84145213058f2) > (reworked dt-bindings to refer to R-Car Gen2 and RZ/G1 only. Well, gen2 support was added upstream by commit 3fe95e6c68e6258410e85488af9e1b1ff545b831, so that should be mentioned here too. It also blacklisted some early gen2 chips; shouldn't that code be included in this backport? > replaced ARCH_RENESAS with ARCH_SHMOBILE in Kconfig. changes to > the driver: > * replaced "renesas,rcar-gen3-wdt" with "renesas,rcar-gen2-wdt" > * added rwdt_set_timeout > * modified rwdt_ping and rwdt_start to leverage rwdt_set_timeout) [...] You explain what you changed, but it's more helpful to explain why. If I'm reading correctly, the set_timeout operation for watchdog drivers is now optional, but was required in 4.4. Could you put that in the commit message? Ben. -- Ben Hutchings, Software Developer ? Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom