From: ben.hutchings@codethink.co.uk (Ben Hutchings)
To: cip-dev@lists.cip-project.org
Subject: [cip-dev] [cip-kernel-sec 2/2] remotes: call _get_configured_remotes
Date: Mon, 17 Jun 2019 21:16:13 +0100 [thread overview]
Message-ID: <1560802573.21054.30.camel@codethink.co.uk> (raw)
In-Reply-To: <20190617022039.7197-2-daniel.sangorrin@toshiba.co.jp>
On Mon, 2019-06-17 at 11:20 +0900, Daniel Sangorrin wrote:
> This is probably a copy&paste mistake that had no effect
> because the contents of _get_configured_remotes and
> _get_configured_branches is the same.
>
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
Maybe it would make more sense to merge the two functions instead?
Ben.
> ---
> ?scripts/kernel_sec/branch.py | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kernel_sec/branch.py
> b/scripts/kernel_sec/branch.py
> index ae1ca2c..3ede64a 100644
> --- a/scripts/kernel_sec/branch.py
> +++ b/scripts/kernel_sec/branch.py
> @@ -209,7 +209,7 @@ def get_remotes(mappings, mainline=None,
> stable=None):
> ?????remotes = RemoteMap()
> ?????remotes.update(_get_configured_remotes('conf/remotes.yml'))
> ?????remotes.update(
> -????????_get_configured_branches(
> +????????_get_configured_remotes(
> ?????????????os.path.expanduser('~/.config/kernel-sec/remotes.yml')))
> ?????for mapping in mappings:
> ?????????left, right = arg.split(':', 1)
--
Ben Hutchings, Software Developer ? Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom
next prev parent reply other threads:[~2019-06-17 20:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 2:20 [cip-dev] [cip-kernel-sec 1/2] remotes: refer to configuration files Daniel Sangorrin
2019-06-17 2:20 ` [cip-dev] [cip-kernel-sec 2/2] remotes: call _get_configured_remotes Daniel Sangorrin
2019-06-17 20:16 ` Ben Hutchings [this message]
2019-06-17 23:48 ` daniel.sangorrin at toshiba.co.jp
2019-06-18 14:42 ` Ben Hutchings
2019-06-17 20:15 ` [cip-dev] [cip-kernel-sec 1/2] remotes: refer to configuration files Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560802573.21054.30.camel@codethink.co.uk \
--to=ben.hutchings@codethink.co.uk \
--cc=cip-dev@lists.cip-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox