Re: Reported 4.4.y-st issue from Flamefire #cip

[theflamefire89@gmail.com]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

> 
> Upstream said this code is correct and affected drivers should be
> fixed, instead,

First this is a practical issue: There are proprietary drivers which likely will never get fixed.
And second I do not agree that this code is correct as it doesn't make sense to me:

- From snd_soc_put_volsw_sx:

if (mc->platform_max && val > mc->platform_max)
	return -EINVAL;
if (val > max - min)
	return -EINVAL;
And from snd_soc_info_volsw called by snd_soc_info_volsw_sx
mc->platform_max = mc->max; So if platform_max gets always set to max why would you compare `val` directly against platform_max but subtract min from max?

Or did upstream say that using a negative "min" is invalid? Example where this is used: https://github.com/sonyxperiadev/kernel/blob/5f3e8612a373f035fae72471dcbc37ec2110adde/sound/soc/codecs/wcd9335.c#L2255-L2256

I also find the following puzzling (in snd_soc_limit_volume): if (max <= mc->max) {
	mc->platform_max = max;

i.e. a check against "max" setting "platform_max"?

Anyway I appreciate you taking care of this and hope the above input helps in guiding a decision.

Best Regards,

Alex

[-- Attachment #2: Type: text/html, Size: 1350 bytes --]