Re: [cip-dev] Request for review for 4.19-st13, 4.19-cip129

[Ulrich Hecht <uli@fpond.eu>]

> On 02/21/2026 6:21 AM CET Nobuhiro Iwamatsu via lists.cip-project.org <iwamatsu=gmail.com@lists.cip-project.org> wrote:
> Hi Uli,
> 
> The following commit requires a fix. Enabling the driver will cause a
> build error.
> 
> c85bc75effc21 fbdev: ssd1307fb: fix potential page leak in ssd1307fb_probe()
> ```
> drivers/video/fbdev/ssd1307fb.c: In function 'ssd1307fb_probe':
> drivers/video/fbdev/ssd1307fb.c:726:22: error: passing argument 1 of
> '__free_pages' from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>   726 |         __free_pages(vmem, get_order(vmem_size));
>       |                      ^~~~
>       |                      |
>       |                      u8 * {aka unsigned char *}
> In file included from ./include/linux/idr.h:16,
>                  from ./include/linux/kernfs.h:14,
>                  from ./include/linux/sysfs.h:16,
>                  from ./include/linux/kobject.h:20,
>                  from ./include/linux/device.h:16,
>                  from ./include/linux/backlight.h:12,
>                  from drivers/video/fbdev/ssd1307fb.c:9:
> ./include/linux/gfp.h:566:39: note: expected 'struct page *' but
> argument is of type 'u8 *' {aka 'unsigned char *'}     566 | extern
> void __free_pages(struct page *page, unsigned int order);
>       |                          ~~~~~~~~~~~~~^~~~
> ```
> 
> This can be fixed by cast to vmem.

Fixed, thanks!

CU
Uli