From: pavel@denx.de (Pavel Machek)
To: cip-dev@lists.cip-project.org
Subject: [cip-dev] [PATCH 4.19.y-cip 05/12] phy: renesas: rcar-gen3-usb2: add conditions for uses_otg_pins == false
Date: Tue, 16 Jul 2019 14:05:19 +0200 [thread overview]
Message-ID: <20190716120519.GG24157@amd> (raw)
In-Reply-To: <1563199312-18842-6-git-send-email-biju.das@bp.renesas.com>
Hi!
> @@ -212,6 +212,9 @@ static void rcar_gen3_init_from_a_peri_to_a_host(struct rcar_gen3_chan *ch)
>
> static bool rcar_gen3_check_id(struct rcar_gen3_chan *ch)
> {
> + if (!ch->uses_otg_pins)
> + return (ch->dr_mode == USB_DR_MODE_HOST) ? false : true;
I'd write this as
"return ch->dr_mode != USB_DR_MODE_HOST;"
I'll take the patch, anyway, but there's room for future cleanup.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20190716/1f9fc841/attachment.sig>
next prev parent reply other threads:[~2019-07-16 12:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 14:01 [cip-dev] [PATCH 4.19.y-cip 00/12] Add USB Host support Biju Das
2019-07-15 14:01 ` [cip-dev] [PATCH 4.19.y-cip 01/12] phy: renesas: rcar-gen3-usb2: fix vbus_ctrl for role sysfs Biju Das
2019-07-15 14:01 ` [cip-dev] [PATCH 4.19.y-cip 02/12] phy: renesas: rcar-gen3-usb2: Rename has_otg_pins to uses_otg_pins Biju Das
2019-07-15 14:01 ` [cip-dev] [PATCH 4.19.y-cip 03/12] phy: renesas: rcar-gen3-usb2: Check a property to use otg pins Biju Das
2019-07-15 14:01 ` [cip-dev] [PATCH 4.19.y-cip 04/12] phy: renesas: rcar-gen3-usb2: unify OBINTEN handling Biju Das
2019-07-16 12:03 ` Pavel Machek
2019-07-16 12:57 ` Biju Das
2019-07-15 14:01 ` [cip-dev] [PATCH 4.19.y-cip 05/12] phy: renesas: rcar-gen3-usb2: add conditions for uses_otg_pins == false Biju Das
2019-07-16 12:05 ` Pavel Machek [this message]
2019-07-16 12:50 ` Biju Das
2019-07-15 14:01 ` [cip-dev] [PATCH 4.19.y-cip 06/12] phy: renesas: rcar-gen3-usb2: change a condition "dr_mode" Biju Das
2019-07-15 14:01 ` [cip-dev] [PATCH 4.19.y-cip 07/12] phy: renesas: rcar-gen3-usb2: add is_otg_channel to use "role" sysfs Biju Das
2019-07-15 14:01 ` [cip-dev] [PATCH 4.19.y-cip 08/12] phy: renesas: rcar-gen3-usb2: follow the hardware manual procedure Biju Das
2019-07-16 12:18 ` Pavel Machek
2019-07-16 12:49 ` Biju Das
2019-07-15 14:01 ` [cip-dev] [PATCH 4.19.y-cip 09/12] phy: rcar-gen3-usb2: Add support for r8a77470 Biju Das
2019-07-15 14:01 ` [cip-dev] [PATCH 4.19.y-cip 10/12] phy: renesas: rcar-gen3-usb2: Use pdev's device pointer on dev_vdbg() Biju Das
2019-07-15 14:01 ` [cip-dev] [PATCH 4.19.y-cip 11/12] phy: renesas: rcar-gen3-usb2: enable/disable independent irqs Biju Das
2019-07-15 14:01 ` [cip-dev] [PATCH 4.19.y-cip 12/12] arm64: dts: renesas: cat874: Add USB-HOST support Biju Das
2019-07-16 16:46 ` [cip-dev] [PATCH 4.19.y-cip 00/12] Add USB Host support Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716120519.GG24157@amd \
--to=pavel@denx.de \
--cc=cip-dev@lists.cip-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox