public inbox for cip-dev@lists.cip-project.org
 help / color / mirror / Atom feed
From: pavel@denx.de (Pavel Machek)
To: cip-dev@lists.cip-project.org
Subject: [cip-dev] [PATCH 4.19.y-cip 1/6] arm64: dts: renesas: r8a774c0-cat874: Add LEDs support
Date: Tue, 16 Jul 2019 22:26:02 +0200	[thread overview]
Message-ID: <20190716202602.GC9557@amd> (raw)
In-Reply-To: <1563200930-39297-2-git-send-email-biju.das@bp.renesas.com>

Hi!

> index f08778e..af396bb 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> @@ -22,6 +22,30 @@
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led0 {
> +			gpios = <&gpio5 19 GPIO_ACTIVE_HIGH>;
> +			label = "LED0";
> +		};
> +
> +		led1 {
> +			gpios = <&gpio3 14 GPIO_ACTIVE_HIGH>;
> +			label = "LED1";
> +		};
> +
> +		led2 {
> +			gpios = <&gpio4 10 GPIO_ACTIVE_HIGH>;
> +			label = "LED2";
> +		};
> +
> +		led3 {
> +			gpios = <&gpio6 4 GPIO_ACTIVE_HIGH>;
> +			label = "LED3";
> +		};
> +	};

With my LED maintainer hat on... these are not exactly useful LED
names. Do they have any fixed meaning? Are they labeled on the board?
What color are they?

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20190716/6f76ff3f/attachment.sig>

  reply	other threads:[~2019-07-16 20:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 14:28 [cip-dev] [PATCH 4.19.y-cip 0/6] Add LED/WDT support Biju Das
2019-07-15 14:28 ` [cip-dev] [PATCH 4.19.y-cip 1/6] arm64: dts: renesas: r8a774c0-cat874: Add LEDs support Biju Das
2019-07-16 20:26   ` Pavel Machek [this message]
2019-07-17  6:59     ` Biju Das
2019-07-17  9:39       ` Pavel Machek
2019-07-15 14:28 ` [cip-dev] [PATCH 4.19.y-cip 2/6] arm64: dts: renesas: r8a774c0-cat874: Add RWDT support Biju Das
2019-07-16 20:27   ` Pavel Machek
2019-07-17  7:40     ` Biju Das
2019-07-17  9:41       ` Pavel Machek
2019-07-15 14:28 ` [cip-dev] [PATCH 4.19.y-cip 3/6] arm64: dts: renesas: r8a774c0: Enable DMA for SCIF2 Biju Das
2019-07-15 14:28 ` [cip-dev] [PATCH 4.19.y-cip 4/6] arm64: dts: renesas: r8a774c0: Fix SCIF5 DMA channels Biju Das
2019-07-15 14:28 ` [cip-dev] [PATCH 4.19.y-cip 5/6] arm64: dts: renesas: r8a774c0: Remove invalid compatible value for CSI40 Biju Das
2019-07-15 14:28 ` [cip-dev] [PATCH 4.19.y-cip 6/6] arm64: dts: renesas: r8a774c0: sort subnodes of the soc node Biju Das
2019-07-17  9:47 ` [cip-dev] [PATCH 4.19.y-cip 0/6] Add LED/WDT support Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190716202602.GC9557@amd \
    --to=pavel@denx.de \
    --cc=cip-dev@lists.cip-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox