public inbox for cip-dev@lists.cip-project.org
 help / color / mirror / Atom feed
From: pavel@ucw.cz (Pavel Machek)
To: cip-dev@lists.cip-project.org
Subject: [cip-dev] [PATCH linux-4.19.y-cip-rt] staging: m57621-mmc: delete driver from the tree.
Date: Thu, 8 Aug 2019 23:53:38 +0200	[thread overview]
Message-ID: <20190808215338.GA12892@amd> (raw)
In-Reply-To: <bff48726-afc7-0676-b189-dad8ca1d559a@siemens.com>

Hi!

> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> The license text in this driver is "interesting" and not really obvious
> that it is supposed to be able to be distributed in the kernel source
> tree.  Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but
> to be safe, I am deleting this driver.  I will be glad to add it back if
> the license is properly sorted out, but for now, this isn't worth the
> potential risk, I should have never taken it in the first place.


> Found to be "interesting" also by our license analysis. I think it's
> best to purge it in CIP as well. Staging is out of scope for us
> anyway.

Greetings to your lawyers ;-). The code is clearly derived work of
kernel, so it has to be GPL, if Mediatek wants it or not.

> -module_init(mt_msdc_init);
> -module_exit(mt_msdc_exit);
> -MODULE_LICENSE("GPL");
> -MODULE_DESCRIPTION("MediaTek MT6575 SD/MMC Card Driver");
> -MODULE_AUTHOR("Infinity Chen <infinity.chen@mediatek.com>");

And Mediatek says so here.

Now, nobody is using that one, so removing it does little damage.

On the other hand.... nobody is using that one. You are unlikely to
build it into your product. And yes, I can apply the patch; I'd prefer
to get it from -stable... But that will not solve the problem.

_We will be still distributing that driver_, even if I remove it. git
will just mark it as removed, it will still be in
repository. (Granted, it will help with generated tarballs).

Best regards,
    	    	  	       	    	     	       	      Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20190808/7e50ea3f/attachment.sig>

  reply	other threads:[~2019-08-08 21:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08 11:49 [cip-dev] [PATCH linux-4.19.y-cip-rt] staging: m57621-mmc: delete driver from the tree Jan Kiszka
2019-08-08 21:53 ` Pavel Machek [this message]
2019-08-09  5:04   ` Jan Kiszka
2019-08-09  5:07     ` Jan Kiszka
2019-08-09  7:12       ` Zoran S
2019-08-09 13:23   ` Ben Hutchings
2019-08-15  9:35 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190808215338.GA12892@amd \
    --to=pavel@ucw.cz \
    --cc=cip-dev@lists.cip-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox