From mboxrd@z Thu Jan 1 00:00:00 1970 From: pavel@ucw.cz (Pavel Machek) Date: Thu, 8 Aug 2019 23:53:38 +0200 Subject: [cip-dev] [PATCH linux-4.19.y-cip-rt] staging: m57621-mmc: delete driver from the tree. In-Reply-To: References: Message-ID: <20190808215338.GA12892@amd> To: cip-dev@lists.cip-project.org List-Id: cip-dev.lists.cip-project.org Hi! > From: Greg Kroah-Hartman > > The license text in this driver is "interesting" and not really obvious > that it is supposed to be able to be distributed in the kernel source > tree. Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but > to be safe, I am deleting this driver. I will be glad to add it back if > the license is properly sorted out, but for now, this isn't worth the > potential risk, I should have never taken it in the first place. > Found to be "interesting" also by our license analysis. I think it's > best to purge it in CIP as well. Staging is out of scope for us > anyway. Greetings to your lawyers ;-). The code is clearly derived work of kernel, so it has to be GPL, if Mediatek wants it or not. > -module_init(mt_msdc_init); > -module_exit(mt_msdc_exit); > -MODULE_LICENSE("GPL"); > -MODULE_DESCRIPTION("MediaTek MT6575 SD/MMC Card Driver"); > -MODULE_AUTHOR("Infinity Chen "); And Mediatek says so here. Now, nobody is using that one, so removing it does little damage. On the other hand.... nobody is using that one. You are unlikely to build it into your product. And yes, I can apply the patch; I'd prefer to get it from -stable... But that will not solve the problem. _We will be still distributing that driver_, even if I remove it. git will just mark it as removed, it will still be in repository. (Granted, it will help with generated tarballs). Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: