From: pavel@denx.de (Pavel Machek)
To: cip-dev@lists.cip-project.org
Subject: [cip-dev] [PATCH 4.4.y-cip 05/17] phy: phy-rcar-gen2: Add support for r8a77470
Date: Wed, 28 Aug 2019 13:12:09 +0200 [thread overview]
Message-ID: <20190828111209.GB8052@amd> (raw)
In-Reply-To: <1566982115-11148-6-git-send-email-biju.das@bp.renesas.com>
Hi!
PHYS_PER_CHANNEL is 2.
> + const u32 (*select_value)[PHYS_PER_CHANNEL];
This is ... quite "interesting" declaration. Does it actually match
the arrays below?
If I read it correctly:
const u32 (...)[PHYS_PER_CHANNEL]
this is array of two items.
> +static const u32 pci_select_value[][PHYS_PER_CHANNEL] = {
> + [0] = { USBHS_UGCTRL2_USB0SEL_PCI, USBHS_UGCTRL2_USB0SEL_HS_USB },
> + [2] = { USBHS_UGCTRL2_USB2SEL_PCI, USBHS_UGCTRL2_USB2SEL_USB30 },
> +};
But here we have three items (0, 1 and 2), yet we are assigning that
to same pointer.
Correct me if I'm wrong.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20190828/559202eb/attachment.sig>
next prev parent reply other threads:[~2019-08-28 11:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 8:48 [cip-dev] [PATCH 4.4.y-cip 00/17] Add USB2.0 support Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 01/17] dt-bindings: phy: rcar-gen2: Add r8a7744 support Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 02/17] dt-bindings: phy: rcar-gen2: Add r8a77470 support Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 03/17] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver Biju Das
2019-08-28 11:02 ` Pavel Machek
2019-08-28 12:20 ` Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 04/17] dt-bindings: rcar-gen3-phy-usb2: Add r8a77470 support Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 05/17] phy: phy-rcar-gen2: Add support for r8a77470 Biju Das
2019-08-28 11:12 ` Pavel Machek [this message]
2019-08-28 12:49 ` Biju Das
2019-08-29 6:59 ` Pavel Machek
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 06/17] phy: rcar-gen3-usb2: " Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 07/17] ARM: dts: r8a77470: Add USB-DMAC device nodes Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 08/17] ARM: dts: r8a77470: Add USB PHY DT support Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 09/17] ARM: dts: r8a77470: Add USB2.0 Host (EHCI/OHCI) device Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 10/17] ARM: shmobile: Enable PHY_RCAR_GEN3_USB2 in shmobile_defconfig Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 11/17] ARM: shmobile: Enable USB [EO]HCI HCD PLATFORM support " Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 12/17] ARM: dts: iwg23s-sbc: Enable USB Phy[01] Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 13/17] ARM: dts: iwg23s-sbc: Enable USB USB2.0 Host Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 14/17] dt-bindings: usb: renesas_usbhs: Add support for r8a7744 Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 15/17] dt-bindings: usb: renesas_usbhs: Add support for r8a77470 Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 16/17] ARM: dts: r8a77470: Add HSUSB device nodes Biju Das
2019-08-28 8:48 ` [cip-dev] [PATCH 4.4.y-cip 17/17] ARM: dts: iwg23s-sbc: Enable HS-USB Biju Das
2019-08-29 7:00 ` [cip-dev] [PATCH 4.4.y-cip 00/17] Add USB2.0 support Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828111209.GB8052@amd \
--to=pavel@denx.de \
--cc=cip-dev@lists.cip-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox