Re: [PATCH 4.19.y-cip 01/23] device connection: Add fwnode member to struct device_connection

Marian-Cristian Rotariu
2020-02-19T19:11:05Z

> > From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >
> > commit 09aa11cfda9d8186046bcd1adcd6498b688114f4 upstream.
> >
> > This will prepare the device connection API for connections described
> > in firmware.
>
> > @@ -753,11 +753,17 @@ struct device_dma_parameters {
> > */
> > struct device_connection {
> > + struct fwnode_handle *fwnode;
> > const char *endpoint[2];
> > const char *id;
> > struct list_head list;
>
> Ok, so this really needs to be 0-initialized in all cases, or we'll be breaking
> existing setups. Are we reasonably sure that's the case?

Yes, I need to add two 0-initialization to the following drivers:
drivers/platform/x86/intel_cht_int33fe.c
drivers/extcon/extcon-axp288.c

In upstream, these drivers opt for fwnode node discovery instead of device_connection definitions.
I will do the modifications in v2.

Thanks,
Marian